fix(wdk, dapp-client): fix cron lastRun persistence and disambiguate redirect payloads#1018
Open
Ysh204 wants to merge 4 commits into
Open
fix(wdk, dapp-client): fix cron lastRun persistence and disambiguate redirect payloads#1018Ysh204 wants to merge 4 commits into
Ysh204 wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR resolves two key issues:
lastRuntimestamps were overwritten to0inlocalStorage, leading to background jobs running too frequently.é) were incorrectly parsed as valid UTF-8 sequences (é), corrupting the data.Solution
lastRuntimes with the persisted value loaded from storage prior to running checks. This prevents overwriting the stored value with0when a job does not execute.encoding=utf-8search parameter to redirect request and response URLs. The client now decodes using UTF-8 only when theencoding=utf-8parameter is present, otherwise safely falling back to Latin-1.Verification
packages/wallet/wdk/test/cron.test.ts.packages/wallet/dapp-client/test/DappTransport.test.tsusing legacy payload textéto ensure no regression occurs.