fix: don't re-enter pre mode on develop after a stable version bump - #500
Open
fabiankaegy wants to merge 1 commit into
Open
fabiankaegy wants to merge 1 commit into
fabiankaegy wants to merge 1 commit into
Conversation
After exiting pre mode, merging the Version Packages PR on develop deleted pre.json. The "Enter pre next" step then re-entered pre mode on the runner, so the stable 7.0.0 releases were published to the @next dist-tag. Only enter pre mode when there are pending changesets, and pin the GitHub "Latest" badge to the toolkit release after a stable publish. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What went wrong with 7.0.0
We exited pre mode on develop (
94e2cc7) and merged the Version Packages PR (#498) into develop. That version bump deleted.changeset/pre.json. On the next Release run, theEnter pre nextstep saw nopre.jsonand put the runner back into pre mode.changeset publishthen sent the stable7.0.0/5.0.0/4.0.0/3.0.0builds to thenextdist-tag, solateststayed on 6.5.1.Separately, GitHub gave the "Latest" badge to
@10up/eslint-config@5.0.0. changesets creates one release per package, and GitHub marks the last stable one created as Latest.These have been fixed by hand: the npm dist-tags were moved, the badge now sits on the toolkit release, and trunk was fast-forwarded to develop.
Changes
Enter pre nextnow only enters pre mode when there are pending changesets. A run right after a stable version bump has none, so it publishes tolatest.10up-toolkitrelease whenever a stable toolkit version is published.🤖 Generated with Claude Code