Fix: max_num_pages becomes negative when posts_per_page is -1 - #4336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
When running a
WP_Queryposts_per_page => -1, ElasticPress was calculatingmax_num_pagesasceil( found_posts / -1 ), producing a negative value (for example,-17when 17 posts were found). WordPress core treatsposts_per_page => -1as "return all posts" and leavesmax_num_pagesat0because pagination does not apply.Closes #4334
How to test the Change
Changelog Entry
Credits
Props @burhandodhy @dmitrijCraq
Checklist: