Repository navigation
fix(ios): truthful cook result, untinted Home card, Chinese dates, stale tags - #45
Open
1395490241lhj-code wants to merge 1 commit into
Open
1395490241lhj-code wants to merge 1 commit into
1395490241lhj-code wants to merge 1 commit into
Conversation
…ale tags Five problems found by running the app on the simulator (second audit): - Cook confirmation: the result always said 已记录消耗,库存已更新, even when nothing was deducted (126 of 165 curated recipes have no quantities). CookConsumptionStockResult is now read from the receipt the confirmation wrote and drives the sheet headline and style, the D-047 stock line and title, and the Planner toast. didConfirm is derived from it. The Special Plan UI seed stocks 嫩豆腐 so its D-047 assertion is true. - Home decision card: the lighting gradient was an overlay above the content and washed 加入今天 to 2.93:1. It now sits beneath the content. - Dates: the bundle is localized only in English, so DatePickers and .formatted(date:) text rendered "Nov 7, 2026". Every DatePicker uses kitchenDateLocale() and every date string uses KitchenDateStyle (zh_Hans_CN, D-018), pinned per view so number fields keep the device region's decimal rules. A Node guard keeps both pinned. - Inventory: a cooked dish no longer tags its ingredients 今晚 · <dish>. - Home recommendations: a local card whose recipe left the library (deleted, local data cleared) is dropped without re-ranking the rest; the member stays on their card, an emptied list reloads the defaults, and recipes that still resolve (retired library dishes, samples, AI cards) stay. Tests: new CookConsumptionStockResultTests, InventoryTonightLinkageTests, HomeRecommendationStoreTests cases, a rendered-pixel check in UIFeedbackTests, UI assertions in RecipeCookingModeUITests and SpecialPlanMenuUITests, and test/ios-native-date-locale.test.mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #42 (base
claude/km-ux-bug-batch). It retargets tomainonce #42 merges.Five problems found by running #42's build on the simulator during the second audit.
Changes
Cook result tells the truth. The confirmation always said 已记录消耗,库存已更新, even when nothing was deducted: 126 of the 165 curated recipes carry no quantities, so most cooks deduct nothing. A new
CookConsumptionStockResultis read from the receipt the confirmation actually wrote. It drives the sheet's headline and style, the D-047 stock line and title, and the Planner toast:didConfirmis now derived from the result. The Special Plan UI seed now stocks 嫩豆腐, so the D-047 UI test's 库存已更新 assertion describes a real deduction.Home recommendation card no longer washed out. The decision surface's lighting gradient was an
.overlaydrawn above the content. That turned 加入今天 into white on light blue (measured 2.93:1) and greyed the text. The gradient now sits beneath the content. Light and Dark screenshots were checked.Dates in Chinese. The bundle is localized only in English, so DatePickers and
.formatted(date:)text rendered "Nov 7, 2026".kitchenDateLocale(), and every date string usesKitchenDateStyle(zh_Hans_CN, per D-018).test/ios-native-date-locale.test.mjskeeps both kinds of date pinned.今晚 tags. A dish that has been cooked no longer tags its ingredients 今晚 · .
Deleted recipes leave Home. A local card whose recipe left the library (deleted, or local data cleared) is dropped without re-ranking the rest:
Validation
All runs used
xcodebuildon Claude's reserved simulator throughdev-sim-slot, not Xcode MCP.Unit tests: full
KitchenManagerTestsran 2926 tests, 0 failures, 5 skipped.Red probe: the new fix: preserve grounded recipe evidence within bounded limits #2, iOS UI Foundation Phase 0: Feedback and Accessibility Baseline #4 and iOS Home UI Phase 1: Hierarchy and Action Refinement #5 tests were run with those fixes temporarily switched off, and failed for the expected reasons. The fix: persist generated IDs for legacy shopping items without IDs #1 and fix: restore Node matrix and AppIcon test stability #3 tests rely on new API, so they can only fail to compile on the old code.
UI tests: 87 runs with
-testLanguage enacross:Two failed:
testInventoryBottomContentClearsFloatingTabBarandtestRecipeListFinalRowClearsFloatingTabBar, both with "no TabBar". They fail identically on the unchanged base, so this is a local iOS 27.2 runtime issue; CI's iOS 26.5 runs had passed them.Node: 207 iOS source-contract tests pass.
Review: an independent review ran before and after implementation (multi-lens, adversarially verified). The confirmed findings are fixed in this PR.
Not in this PR
🤖 Generated with Claude Code