Repository navigation
Link MobilePlatform.cpp - #1
Open
boebie-dev wants to merge 7 commits into
Open
boebie-dev wants to merge 7 commits into
boebie-dev wants to merge 7 commits into
Conversation
Report for GTYE69 (22d5483 - 454b7b8)📈 Matched code: 27.75% (+0.19%, +4540 bytes) ✅ 21 new matches
📈 3 improvements in unmatched items
|
Owner
|
Looks great. Before merging, going through the debug build to get inlines correct would be great. |
1superchip
reviewed
Oct 9, 2026
| // Face the platform towards the second waypoint | ||
| // mixing pWayPoints and mpfLoadInfo is needed to match | ||
| float dx = mpfLoadInfo.wayPoints.vecs[1].x - mpfLoadInfo.wayPoints.vecs[0].x; | ||
| float dz = mpfLoadInfo.wayPoints.vecs[1].z - pWayPoints->vecs[0].z; |
Owner
There was a problem hiding this comment.
From local testing, the variable is not needed.
1superchip
reviewed
Oct 9, 2026
|
|
||
| if (GetDesc()->bobSpeed) { | ||
| MobilePlatformDesc* pDesc = GetDesc(); | ||
| bobFrameOffset = (gDisplay.fps * RandomFR(&gb.mRandSeed, 0.0f, 1.0f)) / pDesc->bobSpeed; |
Owner
There was a problem hiding this comment.
variable for pDesc is not needed
Names not taken from debug symbols or a .ini key are marked with "Unofficial"
boebie-dev
force-pushed
the
mobile-platform
branch
from
October 11, 2026 00:53
d30de1e to
9e937d0
Compare
boebie-dev
marked this pull request as ready for review
October 11, 2026 00:55
Owner
|
Is there a reason to mark all names with "Unofficial"? if this was done consistently, "Unofficial" would be everywhere in the decomp. |
1superchip
reviewed
Oct 13, 2026
| extern "C" double atan2(double, double); | ||
| void GameCamera_AddDynamicCollisionItem(Model* pModel, int subObjectIndex); | ||
|
|
||
| static ModuleInfo<MobilePlatform> mobilePlatformModuleInfo; // Unofficial |
Owner
There was a problem hiding this comment.
This variable name should not have been guessed as it is a variable in the symbols. So it is not "Unofficial"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still need to tag some names that weren't taken from original sources.