Repository navigation
Link TurningPlatform.cpp - #2
Open
boebie-dev wants to merge 2 commits into
Open
boebie-dev wants to merge 2 commits into
boebie-dev wants to merge 2 commits into
Conversation
Match TurningPlatform::Update by normalising ang1 into the parameter in GetSmallestAngle (Tools_TurnToAngle still matches).
boebie-dev
marked this pull request as ready for review
October 11, 2026 13:51
boebie-dev
commented
Oct 11, 2026
| inline float GetSmallestAngle(float ang1, float ang2) { | ||
| float ang = NormaliseAngle(ang2) - NormaliseAngle(ang1); | ||
| ang1 = NormaliseAngle(ang1); | ||
| float ang = NormaliseAngle(ang2) - ang1; |
Owner
|
Is there a reason to mark all names with "Unofficial"? if this was done consistently, "Unofficial" would be everywhere in the decomp. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompiles and links TurningPlatform.cpp (Matching).
TurningPlatform::UpdateneededGetSmallestAngleinStdMath.hto assignNormaliseAngle(ang1)back into the parameter before subtracting; otherwise MWCC loadsangles[targetAngle]ahead ofangles[currAngle]and the registers swap. The only other user,Tools_TurnToAngle, still matches and the DOL sha1 check passes.Names not taken from symbols or ini keys are marked "Unofficial".