01a09c37 - About me on owner, view, and member JSON - #133
Draft
TaprootFreakAI wants to merge 31 commits into
Draft
TaprootFreakAI wants to merge 31 commits into
TaprootFreakAI wants to merge 31 commits into
Conversation
TaprootFreakAI
changed the title
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
6 times, most recently
from
September 14, 2026 16:51
a6df5cf to
bd389ad
Compare
Collaborator
Author
|
EN: DE: Details#134 is merged on develop. Rebase this branch onto current develop before continuing About me ( |
Collaborator
Author
|
EN: DE: DetailsReplacement: #134 (merged). Unique About me work ( |
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
from
September 14, 2026 18:57
5545841 to
565b327
Compare
TaprootFreakAI
changed the title
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
from
September 14, 2026 19:45
565b327 to
0e89c88
Compare
TaprootFreakAI
marked this pull request as ready for review
September 14, 2026 20:34
TaprootFreakAI
marked this pull request as draft
September 14, 2026 23:52
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
from
September 14, 2026 23:58
0e89c88 to
417e63e
Compare
Collaborator
Author
|
EN: DE: DetailsHead |
TaprootFreakAI
marked this pull request as ready for review
September 15, 2026 01:15
TaprootFreakAI
marked this pull request as draft
September 15, 2026 09:17
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
3 times, most recently
from
September 15, 2026 10:55
21ad4a3 to
221c1b8
Compare
Treat the auto-created profile note as a bio when its text is not the display name. Owner, view, and member JSON include aboutMe. Owners can write or clear it without a Lightning Address.
Parallel PUT /me/about without a Lightning Address now deletes the loser note when another profileMessageId already won. Activity fixtures expect fx.quotes from the historical CHF/EUR/PHP stats stand.
The browser origin is the apex; PUT /me/about must survive the preflight. DELETE was already listed; PUT was missing.
SPEC and handbook now match GET /gifts/stats: missing CHF/EUR/PHP stays JSON null and a fiat ensure throw is 200. Passkey finish JSON includes aboutMe. Members aboutMe is null when the note is missing or soft-hidden.
Account.location is required after the location field landed on develop. Keep the new tests compiling by setting location null on those fixtures.
location and aboutMe are on the card; the titles still said six.
Staff-hidden notes stay hidden. PUT /me/about and ensureProfileMessage create a new live note and rehang profileMessageId. Given zap matching keeps the oldest ingest when two indexed rows share a payment hash.
fx.quotes now lists CHF/EUR/PHP when any selected day has that cross, not only the given side. PUT /me/about and ensureProfileMessage docs treat a soft-hidden profile note as missing.
SPEC CORS methods match the boot allow-list including PUT. The owner serializer handbook cites the deletedAt live-note check.
…nter About me now treats note text equal to the stored profile-note name as unfilled, so Ada→Grace does not expose the auto-copy as a bio. PUT /me/about and ensureProfileMessage set profileMessageId only while the pointer still matches the missing or hidden read.
serializeOwnerAccountWithPosts handbook pointed at 196 after the aboutMeFromNote call; the deletedAt === null check is on 195.
MeRouteDeps.messages TSDoc still said profile notes need a Lightning Address. PUT /me/about only requires a name, and GET /me/activity reads payer invoices and indexed zaps from the same store.
…he handbook Keep-both after gift-as-reply dropped getAccountByPubkey from the class catalogue and glued listInvoiceAttemptsForPayer onto zap ingests. Document updateText next to the other MessageStore writers.
ViewRouteDeps.messages and MembersRouteDeps.messageStore now match MeRouteDeps: About me plus activity zaps/invoices. ensureProfileMessage claims profileMessageId instead of saying it stores the pointer.
ensureProfileMessage no longer overwrites profileMessageId. SPEC and the endpoint handbook now match PUT /me/about: the pointer is claimed only while it still matches the missing or hidden read.
ViewRouteDeps names the forum collaborator messageStore, matching develop.
The omitted-deps branch of GET /view/:viewKey was uncounted after the rebase.
Keep-both onto develop left oldest-first ingest matching and union fx in account-activity, plus duplicate CONTRIBUTING tree lines. About me is shipped without Lightning Address; FLOWS identity copy now says so.
Rebase keep-both of notifyForumPost, accountHasLiveTopLevelPost, and About me left long Purpose lines that Prettier wraps.
A won no-LN create calls notifyForumPost after the text write, matching ensureProfileMessage. Updating an already-live note still does not fan out.
Empty or whitespace text keeps a live note and writes empty text. Missing or hidden notes stay missing: no create, no notify. Enqueue failure on a won no-LN create still returns 200.
Empty text clears the bio and keeps a live note. Missing or hidden notes stay missing: no create and no notify.
A won no-LN create now fans in-app rows to every account except the actor, matching POST /messages and ensureProfileMessage. Web Push stays limited to bell subscribers.
ensureProfileMessage from PUT no longer fans out the display-name insert. A won create — Lightning Address ensure or no-LN inline — calls notifyForumPost after updateText.
Missing or hidden notes stay missing only on empty PUT. A non-empty write creates a live note and notifies after the bio.
Adopting another request's live profile note updates the bio but does not fan out a second forum notification.
PUT /me/about no longer inserts a name-copy. A won claim notifies after the bio write; a CAS loser that adopts a live note does not.
SPEC and ensureProfileMessage Used-by now match the inline create path.
PUT /me/about is a forum-text caller. Member and view comments mention the profile note plus About me.
TaprootFreakAI
force-pushed
the
01a09c37-profile-activity
branch
from
September 15, 2026 13:46
1766de0 to
7a7004f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EN:
Adds About me as a profile field, not a forum post.
PUT /me/aboutcreates or clears the profile note without Lightning Address. Owner, member, and public view JSON exposeaboutMe(null when empty, hidden, or a name-copy).DE:
About me ist ein Profilfeld, kein Forum-Post.
PUT /me/aboutlegt die Profilnotiz an oder leert sie, auch ohne Lightning Address. Owner-, Member- und View-JSON liefernaboutMe(null wenn leer, versteckt oder eine Namenskopie).Details
Keep-both rebase onto current develop after account activity landed in #134. This PR does not re-land activity endpoints. Hidden notes count as missing for PUT about. The profile pointer is claimed with CAS (
claimProfileMessageId). Auto name-copy stays unfilled after a rename. CORS allows PUT.