Repository navigation
feat(platform): add macOS support and fix cross-platform agent detection - #3
Merged
Merged
Conversation
Make Windows and macOS first-class supported targets alongside Linux. Agent detection (opencherry_agents): - match exe basenames extension-insensitively so Windows `claude.exe`/ `node.exe` match rules written as `claude`/`node` - recognize Windows shells (cmd, powershell, pwsh, wt, ...) in the require_shell_parent heuristic - normalize path separators so exe-path rules and the Antigravity exclusion match with Windows backslashes - add tests covering Windows exe names, shells, and shell parents Packaging & CI: - add scripts/build-macos.sh producing an unsigned .dmg (with optional cross-arch via OPENCHERRY_MAC_TARGET) - add release-macos.yml building aarch64 + x86_64 .dmg images - add a cross-platform CI matrix running the library crate tests on windows-latest and macos-latest - tauri.conf.json: macOS minimumSystemVersion + NSIS currentUser install - justfile: build-macos / build-windows recipes Docs: README macOS install + per-platform dependency notes; AGENTS.md CI and release workflow notes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014PZXacyXbTKeZEn9uXoPWM
The new cross-platform CI job surfaced two discard_files tests failing on windows-latest: git checkout restored `\n` content as `\r\n` because the runner sets core.autocrlf=true globally. Set core.autocrlf=false and core.eol=lf on the test repo's local config so checkout/discard behavior is deterministic across platforms. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014PZXacyXbTKeZEn9uXoPWM
4nrry
commented
Jun 22, 2026
4nrry
left a comment
Owner
Author
There was a problem hiding this comment.
Revisado! Testei localmente e os builds/testes no backend (Rust) e frontend (SolidJS) passaram com sucesso. O código para o suporte ao macOS parece ótimo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The README already framed macOS and Windows as "supported secondary platforms via Tauri 2", but in practice:
claude,node) and a Unix-only shell list, whilesysinforeportsclaude.exe/node.exeand Windows shells arecmd/powershell/pwsh. No agent would ever be detected..deb) and Windows (NSIS.exe) had build scripts + release workflows, but there was no.dmgscript/workflow.What changed
Agent detection (
opencherry_agents)claude.exe/node.exematch rules written asclaude/node.cmd,powershell,pwsh,wt,conhost,nu, …) in therequire_shell_parentheuristic.\→/) soexe_path_containsrules and the Antigravity exclusion work with Windows paths.Packaging & CI
scripts/build-macos.sh— produces an unsigned.dmg(optional cross-arch viaOPENCHERRY_MAC_TARGET)..github/workflows/release-macos.yml— builds Apple Silicon (aarch64) + Intel (x86_64).dmgimages, attaching tov*releases or uploading as artifacts onworkflow_dispatch..github/workflows/ci.yml— newcross-platformmatrix running the library-crate tests onwindows-latestandmacos-latest.tauri.conf.json— macOSminimumSystemVersion(10.15) and NSIScurrentUserinstall mode (no admin prompt for an unsigned dev tool).justfile—build-macos/build-windowsrecipes.Docs
.dmginstall section + per-platform dependency notes.Testing
cargo fmt --all -- --check✅cargo clippy -p opencherry_core -p opencherry_repo -p opencherry_agents -p opencherry_persistence --all-targets -- -D warnings✅cargo teston all four library crates ✅ (42 tests, including the new Windows-detection tests)bash -n scripts/build-macos.sh✅tauri buildfor.dmg/.exe(needs macOS/Windows hosts — that's what the release workflows are for) and the Linux desktop E2E (no WebKitWebDriver in this environment).🤖 Generated with Claude Code
https://claude.ai/code/session_014PZXacyXbTKeZEn9uXoPWM
Generated by Claude Code