DOC: document ?date= historical public-key lookup and its errors - #211
Merged
Conversation
…gning key rotation in fodid.md and errormessages.md.
Contributor
jwrosewell
requested changes
Jun 19, 2026
jwrosewell
left a comment
jwrosewell
left a comment
Contributor
There was a problem hiding this comment.
Seems incomplete with some items that I think are incorrect.
justadreamer
marked this pull request as draft
June 19, 2026 11:45
Contributor
|
This feature has not shipped yet, so converting the PR to draft |
justadreamer
marked this pull request as ready for review
June 29, 2026 07:37
…to weekly, drop em dashes, document the bulk key endpoint
Contributor
|
the feature has been shipped, so good to merge |
justadreamer
approved these changes
Jul 9, 2026
Contributor
|
closes #170 as well |
The docs should describe what the endpoints do and leave integration decisions to the reader. Removes the "Recommended workflow" key-caching advice (its "at most one extra request per key rotation" claim only holds under assumptions the page never states), the endpoint-choice guidance, the GUID-persistence and HTTPS instructions, and the consent-derivation editorial. pmp.md linked DeviceDetection_OtherIntegrations_Prebid, the "Prebid (Moved)" tombstone cbceeaf replaced, alongside an identical link to the live Integrations_Prebid page. Also aligns the two *lic scope cells with the probabilistic rows and fixes the "Bits 7-6" table header to match the 6-7 ordering used in the prose and in DidOnPremiseEngine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
Extends the Validation section of src/identifiers/fodid.md: how to fetch the public key by date (/creator?date=), the selection rule, the 404, and the recommended verifier workflow (cache the key locally; only send
dateas a fallback after a verification failure, using the 51Did's own Date field).Adds two entries to src/services/cloud/errormessages.md: malformed
date(400) and date too old (404).