Skip to content

chore(demo): fix RTL column reordering example - #1294

Merged
ghiscoding merged 1 commit into
6pac:masterfrom
jahanbakhsh18:fix/sortablejs-rtl-column-reorder
Sep 10, 2026
Merged

ghiscoding merged 1 commit into
6pac:masterfrom
jahanbakhsh18:fix/sortablejs-rtl-column-reorder

Conversation

@jahanbakhsh18

Copy link
Copy Markdown
Contributor

Summary

This PR enables and verifies column reordering in the RTL example.

  • Use the existing sortablejs-rtl distribution for the RTL example.
  • Enable column reordering in the RTL example.
  • Add a note indicating that the RTL-compatible SortableJS distribution is required.
  • Add Cypress coverage for column reordering in both directions.

Implementation

Since SlickGrid consumes SortableJS as an external dependency and the examples already load SortableJS from CDN, I chose to use the existing sortablejs-rtl distribution for the RTL example instead of introducing a patched SortableJS dependency through pnpm.

This keeps the change isolated to the RTL example while providing working RTL column reordering with Cypress coverage.

@ghiscoding ghiscoding changed the title Fix RTL column reordering chore(demo): fix RTL column reordering example Sep 10, 2026
@ghiscoding

Copy link
Copy Markdown
Collaborator

seems ok since it's just for demo purposes, thanks

@ghiscoding
ghiscoding merged commit a4dea00 into 6pac:master Sep 10, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants