Repository navigation
fix(install): make install.ps1 run on Windows PowerShell 3.0 - #251
Merged
Merged
Conversation
Get-FileHash requires Windows PowerShell 4+, so `devo upgrade` fails on 3.0 (the Windows 8 / Server 2012 default) with "Get-FileHash is not recognized" from the Invoke-Expression'd install.ps1. Compute the hash with System.Security.Cryptography directly (uppercase hex, same output shape), and add -UseBasicParsing to the remaining bare Invoke-WebRequest so the IE engine is not required either. Co-Authored-By: Claude Code <noreply@anthropic.com>
Get-CachedDevoRuntime runs in fresh [PowerShell] runspaces that only re-declare Receive-DevoAsset and itself, so its Get-Sha256Hex calls failed with "The term 'Get-Sha256Hex' is not recognized". Embed the helper definition in the worker script like the other two functions. Co-Authored-By: Claude Code <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
devo upgradedownloads and Invoke-Expressionsinstall.ps1, whoseSHA-256 verification relied on
Get-FileHash. That cmdlet only existsfrom Windows PowerShell 4.0, so upgrading on a 3.0 host (Windows 8 /
Server 2012 default WMF) dies with
Get-FileHash is not recognized.Get-Sha256Hexhelper that computes the hash throughSystem.Security.Cryptographydirectly (uppercase hex, identicaloutput shape) and use it at all six verification sites.
-UseBasicParsingto the one bareInvoke-WebRequestso theripgrep download does not depend on the IE engine either.
The installers test harness concatenates this script and runs it, so
CI exercises the new helper end to end.
🤖 Generated with Claude Code