Repository navigation
Use 'A' as accelerator for AI Hub menu to avoid conflict with Help (fixes #137) - #138
Closed
AdamMagued wants to merge 1 commit into
Closed
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
Author
|
closing in favor of #139 where i added dedicated unit test coverage for the menu accelerator. apologies for the duplicate PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In the main NVDA menu, both AI Hub (
AI &Hub) and NVDA's built-in Help (&Help) usedhas their keyboard shortcut accelerator (#137).This change:
AI &Hubto&AI Hubinplugin_mixins.pysoAactivates the menu item andHremains free for NVDA's Help menu._("&AI Hub {addon_version}").format(...)so gettext can look up the message id properly..potranslation files with the new accelerator.Closes #137.