Skip to content

#611: compare MMRD relations without repeating the exponential fit. - #627

Merged
dbenn merged 1 commit into
masterfrom
611-refine-MMRD-plugin
Sep 12, 2026
Merged

dbenn merged 1 commit into
masterfrom
611-refine-MMRD-plugin

Conversation

@dbenn

@dbenn dbenn commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Keep t2/t3 after the first fit, show a sortable summary table of every calibration, and return to the input dialog to try another relation.

Basically allow the user to retry different methods and get a summary of all methods' results.

Keep t2/t3 after the first fit, show a sortable summary table of every
calibration, and return to the input dialog to try another relation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@dbenn
dbenn requested a review from mpyat2 September 9, 2026 13:03
@dbenn dbenn self-assigned this Sep 9, 2026
@dbenn dbenn added enhancement New feature or request plug-in Plug-in Development labels Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Plugin Unit Tests

All tests passed (Java 17)

Metric Value
Tests 39
Passed 39
Failures 0
Errors 0

@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

VStar Unit Tests

Tests failed (Java 17)

Metric Value
Tests 1013
Passed 1012
Failures 1
Errors 0

@mpyat2

mpyat2 commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Hi @dbenn, very interesting plug-in! It works. I tested it on the V4633 Sgr visual observations from the AID using 2450894.5 ≤ JD ≤ 2450954.5, and it gave me a distance of ~13 kpc (with no extinction, well, not far from your estimation). It seems you used different data? It is not entirely clear from the existing MMRD pdf.

@dbenn

dbenn commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator Author

It could be either data or the method selected.

@dbenn
dbenn merged commit 5f0f191 into master Sep 12, 2026
14 of 20 checks passed
@dbenn
dbenn deleted the 611-refine-MMRD-plugin branch September 12, 2026 04:01
@mpyat2

mpyat2 commented Sep 12, 2026

Copy link
Copy Markdown
Collaborator

It could be either data or the method selected.

Sure, it depends on the data; however, it is not clear from MMRD.pdf what data was used (or did I miss the reference?)

@dbenn

dbenn commented Sep 13, 2026 •

Copy link
Copy Markdown
Collaborator Author

You are 100% right @mpyat2 !

Sorry. the figures I've added there in the latest update for the doc don't correspond to V4633 Sgr it seems. I mention that target in Kok (2010) related sections but what's shown in the dialogs is something else.

There are other things that need to be cleaned up in the doc as well.

I'll create a new branch to fix the doc.

Thanks for picking this up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request plug-in Plug-in Development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create a plug-in that implements MMRD method of nova distance determination

2 participants