Repository navigation
Remove side-effects of compute_budget_mld and compute_tracer_at_mlb - #93
Merged
rmholmes merged 3 commits intoAug 31, 2026
Conversation
Collaborator
|
Looks great to me Dougie. What you've implemented is way cleaner than what I had done, which was really a quick-and-dirty, get it working! |
rmholmes
merged commit Aug 31, 2026
26dd1ad
into
mixed_layer_tracer_diagnostics_nri
1 of 6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@rmholmes, this is what I had in mind with my review comment.
I've added private
wrkarrays that are used bycalc_mixed_layer_depthandcompute_budget_mldso that those routines have no side-effects on publicwrkarrays.This means we no longer need to make
wrkarray copies when usingcompute_budget_mldandcompute_tracer_at_mlbin blocks that utilise the publicwrkarrays.I also noticed two bugs along the way so I've fixed those (my second and third commits)
Have a look and if you're happy with this we can merge it into your branch.