Repository navigation
Ice shelf-specific forcing depths #113
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -688,7 +688,7 @@ end subroutine set_pen_shortwave | |||||||||||||
| subroutine applyBoundaryFluxesInOut(CS, G, GV, US, dt, fluxes, optics, nsw, h, tv, & | ||||||||||||||
| aggregate_FW_forcing, evap_CFL_limit, & | ||||||||||||||
| minimum_forcing_depth, cTKE, dSV_dT, dSV_dS, & | ||||||||||||||
| SkinBuoyFlux, MLD_h, frac_shelf_h, shelf_forcing_depth) | ||||||||||||||
| type(diabatic_aux_CS), pointer :: CS !< Control structure for diabatic_aux | ||||||||||||||
| type(ocean_grid_type), intent(in) :: G !< Grid structure | ||||||||||||||
| type(verticalGrid_type), intent(in) :: GV !< ocean vertical grid structure | ||||||||||||||
|
|
@@ -720,6 +720,9 @@ subroutine applyBoundaryFluxesInOut(CS, G, GV, US, dt, fluxes, optics, nsw, h, t | |||||||||||||
| optional, intent(out) :: SkinBuoyFlux !< Buoyancy flux at surface [Z2 T-3 ~> m2 s-3]. | ||||||||||||||
| real, dimension(:,:), & | ||||||||||||||
| optional, pointer :: MLD_h !< Mixed layer thickness for brine plumes [H ~> m or kg m-2] | ||||||||||||||
| real, dimension(SZI_(G),SZJ_(G)), & | ||||||||||||||
| optional, intent(in) :: frac_shelf_h !< Fractional ice shelf coverage [nondim] | ||||||||||||||
| real, optional, intent(in) :: shelf_forcing_depth !< Flux depth for shelf regions | ||||||||||||||
|
Collaborator
There was a problem hiding this comment. Needs units:
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| ! Local variables | ||||||||||||||
| integer, parameter :: maxGroundings = 5 | ||||||||||||||
|
|
@@ -859,7 +862,8 @@ subroutine applyBoundaryFluxesInOut(CS, G, GV, US, dt, fluxes, optics, nsw, h, t | |||||||||||||
| !$OMP minimum_forcing_depth,evap_CFL_limit,dt,EOSdom, & | ||||||||||||||
| !$OMP calculate_buoyancy,netPen_rate,SkinBuoyFlux,GoRho,& | ||||||||||||||
| !$OMP calculate_energetics,dSV_dT,dSV_dS,cTKE,g_Hconv2, & | ||||||||||||||
| !$OMP EnthalpyConst,MLD_h,frac_shelf_h, & | ||||||||||||||
| !$OMP shelf_forcing_depth) & | ||||||||||||||
| !$OMP private(opacityBand,h2d,T2d,netMassInOut,netMassOut, & | ||||||||||||||
| !$OMP netHeat,netSalt,Pen_SW_bnd,fractionOfForcing, & | ||||||||||||||
| !$OMP IforcingDepthScale,g_conv,dSpV_dT,dSpV_dS, & | ||||||||||||||
|
|
@@ -1086,7 +1090,13 @@ subroutine applyBoundaryFluxesInOut(CS, G, GV, US, dt, fluxes, optics, nsw, h, t | |||||||||||||
| ! Place forcing into this layer if this layer has nontrivial thickness. | ||||||||||||||
| ! For layers thin relative to 1/IforcingDepthScale, then distribute | ||||||||||||||
| ! forcing into deeper layers. | ||||||||||||||
| if (present(frac_shelf_h)) then | ||||||||||||||
| IforcingDepthScale = 1. / max(GV%H_subroundoff, & | ||||||||||||||
| frac_shelf_h(i,j) * (shelf_forcing_depth - netMassOut(i)) & | ||||||||||||||
| + (1. - frac_shelf_h(i,j)) * (minimum_forcing_depth - netMassOut(i))) | ||||||||||||||
|
Comment on lines
+1094
to
+1096
Collaborator
There was a problem hiding this comment. Would writing like this be better for preserving answers when
Suggested change
|
||||||||||||||
| else | ||||||||||||||
| IforcingDepthScale = 1. / max(GV%H_subroundoff, minimum_forcing_depth - netMassOut(i) ) | ||||||||||||||
| endif | ||||||||||||||
| ! fractionOfForcing = 1.0, unless h2d is less than IforcingDepthScale. | ||||||||||||||
| fractionOfForcing = min(1.0, h2d(i,k)*IforcingDepthScale) | ||||||||||||||
|
|
||||||||||||||
|
|
||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -161,6 +161,8 @@ module MOM_diabatic_driver | |||||
| !! near the bottom [H Z T-1 ~> m2 s-1 or kg m-1 s-1] | ||||||
| real :: minimum_forcing_depth !< The smallest depth over which heat and freshwater | ||||||
| !! fluxes are applied [H ~> m or kg m-2]. | ||||||
| real :: shelf_forcing_depth !< The smallest depth over which heat and freshwater | ||||||
| !! fluxes are applied under shelves [H ~> m or kg m-2]. | ||||||
| real :: evap_CFL_limit = 0.8 !< The largest fraction of a layer that can be | ||||||
| !! evaporated in one time-step [nondim]. | ||||||
| integer :: halo_TS_diff = 0 !< The temperature, salinity and thickness halo size that | ||||||
|
|
@@ -277,7 +279,7 @@ module MOM_diabatic_driver | |||||
| !> This subroutine imposes the diapycnal mass fluxes and the | ||||||
| !! accompanying diapycnal advection of momentum and tracers. | ||||||
| subroutine diabatic(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, & | ||||||
| G, GV, US, CS, stoch_CS, OBC, Waves, frac_shelf_h) | ||||||
| type(ocean_grid_type), intent(inout) :: G !< ocean grid structure | ||||||
| type(verticalGrid_type), intent(in) :: GV !< ocean vertical grid structure | ||||||
| real, dimension(SZIB_(G),SZJ_(G),SZK_(GV)), intent(inout) :: u !< zonal velocity [L T-1 ~> m s-1] | ||||||
|
|
@@ -301,6 +303,7 @@ subroutine diabatic(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, & | |||||
| type(stochastic_CS), pointer :: stoch_CS !< stochastic control structure | ||||||
| type(ocean_OBC_type), pointer :: OBC !< Open boundaries control structure. | ||||||
| type(Wave_parameters_CS), pointer :: Waves !< Surface gravity waves | ||||||
| real, dimension(:,:), optional, intent(in) :: frac_shelf_h !< Fractional ice shelf coverage [nondim] | ||||||
|
Collaborator
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| ! local variables | ||||||
| real, dimension(SZI_(G),SZJ_(G),SZK_(GV)+1) :: & | ||||||
|
|
@@ -410,7 +413,7 @@ subroutine diabatic(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, & | |||||
| G, GV, US, CS, stoch_CS, Waves) | ||||||
| elseif (CS%useALEalgorithm) then | ||||||
| call diabatic_ALE(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, & | ||||||
| G, GV, US, CS, stoch_CS, Waves, frac_shelf_h) | ||||||
| else | ||||||
| call layered_diabatic(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, & | ||||||
| G, GV, US, CS, Waves) | ||||||
|
|
@@ -1243,7 +1246,7 @@ end subroutine diabatic_ALE_legacy | |||||
| !> This subroutine imposes the diapycnal mass fluxes and the | ||||||
| !! accompanying diapycnal advection of momentum and tracers. | ||||||
| subroutine diabatic_ALE(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, & | ||||||
| G, GV, US, CS, stoch_CS, Waves, frac_shelf_h) | ||||||
| type(ocean_grid_type), intent(inout) :: G !< ocean grid structure | ||||||
| type(verticalGrid_type), intent(in) :: GV !< ocean vertical grid structure | ||||||
| type(unit_scale_type), intent(in) :: US !< A dimensional unit scaling type | ||||||
|
|
@@ -1266,6 +1269,7 @@ subroutine diabatic_ALE(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, | |||||
| type(diabatic_CS), pointer :: CS !< module control structure | ||||||
| type(stochastic_CS), pointer :: stoch_CS !< stochastic control structure | ||||||
| type(Wave_parameters_CS), pointer :: Waves !< Surface gravity waves | ||||||
| real, dimension(:,:), optional, intent(in) :: frac_shelf_h !< Fractional ice shelf coverage [nondim] | ||||||
|
Collaborator
There was a problem hiding this comment.
Suggested change
|
||||||
|
|
||||||
| ! local variables | ||||||
| real, dimension(SZI_(G),SZJ_(G),SZK_(GV)) :: & | ||||||
|
|
@@ -1543,9 +1547,16 @@ subroutine diabatic_ALE(u, v, h, tv, BLD, fluxes, visc, ADp, CDp, dt, Time_end, | |||||
| if (CS%use_energetic_PBL) then | ||||||
|
|
||||||
| skinbuoyflux(:,:) = 0.0 | ||||||
| if (present(frac_shelf_h)) then | ||||||
| call applyBoundaryFluxesInOut(CS%diabatic_aux_CSp, G, GV, US, dt, fluxes, CS%optics, & | ||||||
| optics_nbands(CS%optics), h, tv, CS%aggregate_FW_forcing, CS%evap_CFL_limit, & | ||||||
| CS%minimum_forcing_depth, cTKE, dSV_dT, dSV_dS, SkinBuoyFlux=SkinBuoyFlux, MLD_h=visc%h_ML, & | ||||||
| frac_shelf_h=frac_shelf_h, shelf_forcing_depth=CS%shelf_forcing_depth) | ||||||
| else | ||||||
| call applyBoundaryFluxesInOut(CS%diabatic_aux_CSp, G, GV, US, dt, fluxes, CS%optics, & | ||||||
| optics_nbands(CS%optics), h, tv, CS%aggregate_FW_forcing, CS%evap_CFL_limit, & | ||||||
| CS%minimum_forcing_depth, cTKE, dSV_dT, dSV_dS, SkinBuoyFlux=SkinBuoyFlux, MLD_h=visc%h_ML) | ||||||
| endif | ||||||
|
|
||||||
| if (CS%debug) then | ||||||
| call hchksum(ent_t, "after applyBoundaryFluxes ent_t", G%HI, haloshift=0, unscale=GV%H_to_MKS) | ||||||
|
|
@@ -3214,7 +3225,8 @@ end subroutine adiabatic_driver_init | |||||
| !> This routine initializes the diabatic driver module. | ||||||
| subroutine diabatic_driver_init(Time, G, GV, US, param_file, useALEalgorithm, diag, & | ||||||
| ADp, CDp, CS, tracer_flow_CSp, sponge_CSp, & | ||||||
| ALE_sponge_CSp, oda_incupd_CSp, int_tide_CSp, & | ||||||
| frac_shelf_h) | ||||||
| type(time_type), target :: Time !< model time | ||||||
| type(ocean_grid_type), intent(inout) :: G !< model grid structure | ||||||
| type(verticalGrid_type), intent(in) :: GV !< model vertical grid structure | ||||||
|
|
@@ -3233,6 +3245,7 @@ subroutine diabatic_driver_init(Time, G, GV, US, param_file, useALEalgorithm, di | |||||
| type(oda_incupd_CS), pointer :: oda_incupd_CSp !< pointer to the ocean data assimilation incremental | ||||||
| !! update module control structure | ||||||
| type(int_tide_CS), pointer :: int_tide_CSp !< pointer to the internal tide structure | ||||||
| real, dimension(:,:), optional, intent(in) :: frac_shelf_h !< Fractional ice shelf coverage [nondim] | ||||||
|
Collaborator
There was a problem hiding this comment.
Suggested change
Collaborator
There was a problem hiding this comment. Also, could we pass a logical here instead of the full array (Or just read |
||||||
|
|
||||||
| ! Local variables | ||||||
| real :: Kd ! A diffusivity used in the default for other tracer diffusivities [Z2 T-1 ~> m2 s-1] | ||||||
|
|
@@ -3380,6 +3393,15 @@ subroutine diabatic_driver_init(Time, G, GV, US, param_file, useALEalgorithm, di | |||||
| "relative to this scale, in which case the forcing tendencies "//& | ||||||
| "scaled down by distributing the forcing over this depth scale.", & | ||||||
| units="m", default=0.001, scale=GV%m_to_H) | ||||||
| if (present(frac_shelf_h)) then | ||||||
| call get_param(param_file, mdl, "SHELF_FORCING_DEPTH", CS%shelf_forcing_depth, & | ||||||
| "The smallest depth over which forcing can be applied under an "//& | ||||||
| "ice shelf. This only takes effect under ice shelves, and when "//& | ||||||
| "near-surface layers become thin relative to this scale, in "//& | ||||||
| "which case the forcing tendencies are scaled down by "//& | ||||||
| "distributing the forcing over this depth scale.", & | ||||||
| units="m", default=0.001, scale=GV%m_to_H) | ||||||
|
Comment on lines
+3397
to
+3403
Collaborator
There was a problem hiding this comment.
Should these use |
||||||
| endif | ||||||
| call get_param(param_file, mdl, "EVAP_CFL_LIMIT", CS%evap_CFL_limit, & | ||||||
| "The largest fraction of a layer than can be lost to forcing "//& | ||||||
| "(e.g. evaporation, sea-ice formation) in one time-step. The unused "//& | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fluxesincludesfluxes%frac_shelf_h. As far as I can tell, it's the same asCS%frac_shelf_hfor static ice shelves, but it's updated when the shelf moves, whereasCS%frac_shelf_hisn't. Could/should you usefluxes%frac_shelf_hhere instead of threadingCS%frac_shelf_hthrough?