Repository navigation
Error handling when user can't access BARRA files - #63
Open
ashjbarnes wants to merge 2 commits into
Open
ashjbarnes wants to merge 2 commits into
ashjbarnes wants to merge 2 commits into
Conversation
Currently the error thrown if a user isn't yet on ob53 is cryptic, and not obviously a `file not found` issue. This explicitly tells the user what's wrong if the `barra_files` list is empty
|
This pull request has been mentioned on ACCESS Hive Community Forum. There might be relevant details there: https://forum.access-hive.org.au/t/first-time-ram3-user-feedback/5888/3 |
Author
|
@atteggiani This is the PR I mentioned :) |
Author
|
@atteggiani another member of the community has run into this issue, and confused by the same thing that I was, which I think could have been avoided if this fix had been merged. Could you please either action this PR, refer it to whoever might be responsible for reviewing it, or explain why it won't be implemented and close it |
atteggiani
self-requested a review
September 7, 2026 00:16
atteggiani
requested changes
Sep 7, 2026
atteggiani
left a comment
atteggiani
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for this PR @ashjbarnes.
I think the error handling is needed for a better user experience!
I only added a minor suggestion.
Co-authored-by: Davide Marchegiani <davide.marchegiani@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the error thrown if a user isn't yet on ob53 is cryptic, and not obviously a
file not foundissue. This explicitly tells the user what's wrong if thebarra_fileslist is empty