Skip to content

Add parent model time in experiment-metadata. - #75

Merged
Qian-HuiChen merged 3 commits into
mainfrom
parent-model-time
Aug 26, 2026
Merged

Qian-HuiChen merged 3 commits into
mainfrom
parent-model-time

Conversation

@Qian-HuiChen

Copy link
Copy Markdown
Collaborator

This PR adds a parent_branch_off_time field in metadata.yaml schema. This field records the model time of the parent experiment, when the new branch is created.

Closes #74

@joshuatorrance

Copy link
Copy Markdown
Collaborator

Thanks for the changes!

Should we be making a copy of json file, incrementing the version, and making the changes there?

Comment thread au.org.access-nri/model/output/experiment-metadata/1-0-3.json Outdated

@aidanheerdegen aidanheerdegen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small tweaks, otherwise looks good, thanks!

Comment thread au.org.access-nri/model/output/experiment-metadata/1-0-3.json Outdated
Comment thread au.org.access-nri/model/output/experiment-metadata/1-0-3.json Outdated
@Qian-HuiChen

Copy link
Copy Markdown
Collaborator Author

@joshuatorrance I reckon it is fair to increment the version to 1-0-4. Please find the changes in 1421444

@aidanheerdegen

Copy link
Copy Markdown
Member

Should we be making a copy of json file, incrementing the version, and making the changes there?

Thanks for catching this! I didn't noticed, but did think "I wonder how @Qian-HuiChen has managed to get such a clean diff on the PR. Duh!

FYI you can copy the original file to the new name, make a commit, and then add your changes on top, then it is possible to omit that commit from the diff to get a clean diff of the changes/updates.

@aidanheerdegen aidanheerdegen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Comment thread au.org.access-nri/model/output/experiment-metadata/1-0-4.json
@Qian-HuiChen
Qian-HuiChen merged commit 6ac2957 into main Aug 26, 2026
2 checks passed
@Qian-HuiChen
Qian-HuiChen deleted the parent-model-time branch August 26, 2026 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add parent branch time in experiment metadata.yaml

3 participants