Skip to content

chore: pin fisher and tmux plugins and github-backend mise tools (#84) - #103

Draft
AH-Merii wants to merge 1 commit into
mainfrom
chore/pin-plugins
Draft

AH-Merii wants to merge 1 commit into
mainfrom
chore/pin-plugins

Conversation

@AH-Merii

@AH-Merii AH-Merii commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Every fisher plugin, every TPM plugin, the catppuccin clone and three github:-backed mise tools tracked their default branch, so two machines set up a week apart run different code and a plugin that breaks has no known-good ref to fall back to.

TPM pins by handing the ref to git clone -b, which takes a branch or a tag and not a commit, so the three plugins with no tags upstream cannot be pinned at all and stay floating with a comment saying why. fisher fetches a tarball by ref and accepts a SHA, so its two untagged plugins get one.

Closes #84

@AH-Merii AH-Merii left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worth a read before merging​

set -g @plugin 'tmux-plugins/tmux-battery#v2.0.0'
set -g @plugin 'joshmedeski/tmux-nerd-font-window-name#v3.2.1'
set -g @plugin 'tmux-plugins/tmux-resurrect#v4.0.0'
set -g @plugin 'tmux-plugins/tmux-continuum#v3.1.0'

@AH-Merii AH-Merii Sep 9, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

coinflip: I pinned these to each plugin's latest upstream tag, which for the tmux-plugins ones is a lot older than what this machine is already running.

continuum's v3.1.0 is from 2015 and master is 82 commits past it, sensible's v3.0.0 is 2015 and 20 commits back, resurrect's v4.0.0 is 2022 and 18 commits back. the checkouts in ~/.config/tmux/plugins here are on 2024, 2022 and 2023 commits, and nothing moves them, since TPM's install_plugins skips any plugin whose directory already exists. so this only bites on a fresh machine, which would get the 2015 code.

the alternative is #master on those three, which is what they were doing before this PR and isn't a pin at all. happy to flip any of them back if you'd rather track the branch than freeze a decade-old tag.

Comment thread mise-tasks/plugins

sms_preview plan_plugins 'Install these plugins?' || exit 0

# fish_plugins pins every plugin, fisher itself included (`jorgebucaran/fisher@<tag>`), and

@AH-Merii AH-Merii Sep 9, 2026

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yolo: I couldn't run the branch this hunk changes, the one where functions -q fisher is false and the curl'd copy of fisher does the first fisher update.

fisher is already installed here (~/.local/share/fisher/functions/fisher.fish), so that branch never fires on this machine. to test it, rm -rf ~/.local/share/fisher and mise run plugins, or run the task on a fresh box. what I'd be watching for is whether dropping the fisher install jorgebucaran/fisher that used to follow the curl still leaves you with fisher on the next shell, which it should, since jorgebucaran/fisher@4.4.8 is now the first line of fish_plugins and fisher update installs what's listed there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pin fisher plugins, TPM plugins and github-backend mise tools

1 participant