fix(deps): update module github.com/google/go-github/v88 to v90 - #2198
fix(deps): update module github.com/google/go-github/v88 to v90#2198renovate[bot] wants to merge 1 commit into
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2198 +/- ##
==========================================
+ Coverage 87.86% 88.32% +0.46%
==========================================
Files 395 395
Lines 35481 35481
==========================================
+ Hits 31174 31338 +164
+ Misses 4303 4139 -164
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
🐑 renovate-shepherd triage: needs a human decisionMajor bump ( The diff is a no-op that leaves an unused dependency behindGo major versions are distinct module paths, so Renovate added The one file that actually imports the library still points at v88:
So merging this as-is would add a dependency nothing imports, keep the code on v88, and a later What the real migration looks like
Blast radius on our side is small (one import site), but "small" is not "zero", and crossing two majors of a GitHub API client is a judgment call about behavior, not a mechanical repair. Escalating rather than guessing. CI status is not evidence of compatibility here
Everything else is green — but do not read that as "v90 is source-compatible." Nothing in the build ever loaded v90, because no import references it. — |
4da462a to
15c895d
Compare
15c895d to
3d656d3
Compare
3d656d3 to
a8745bb
Compare
78c5e36 to
a8745bb
Compare
a8745bb to
78c5e36
Compare
This PR contains the following updates:
v88.0.0→v90.0.0Release Notes
google/go-github (github.com/google/go-github/v88)
v90.0.0Compare Source
This release contains the following breaking API changes:
UpdateConnectedExternalGrouprequest body by value via newUpdateConnectedExternalGroupRequest(#4425)BREAKING CHANGE:
TeamsService.UpdateConnectedExternalGroupnow takesUpdateConnectedExternalGroupRequest(with non-pointerGroupID) by value.PullRequestReviewDismissalRequesttoPullRequestDismissReviewRequest, addPullRequestSubmitReviewRequest, and pass review request bodies by value (#4406)BREAKING CHANGE:
PullRequestReviewDismissalRequestis nowPullRequestDismissReviewRequestwith non-pointerMessageandPullRequestsService.DismissReviewtakes it by value;PullRequestsService.SubmitReviewnow takes a newPullRequestSubmitReviewRequest.CreateOrUpdateCustomRepoRoleOptionsintoCreateCustomRepoRoleRequestandUpdateCustomRepoRoleRequestand pass by value (#4401)BREAKING CHANGE:
CreateOrUpdateCustomRepoRoleOptionsis split intoCreateCustomRepoRoleRequest(with non-pointerNameandBaseRole) andUpdateCustomRepoRoleRequest;OrganizationsService.CreateCustomRepoRoleandUpdateCustomRepoRolenow take these request types by value.EditLabeltoUpdateLabel, SplitLabelintoCreateLabelRequest&UpdateLabelRequestand pass by value (#4400)BREAKING CHANGE:
IssuesService.CreateLabelnow takesCreateLabelRequestby value (with required non-pointerName);IssuesService.EditLabelrenamed toUpdateLabel, taking anUpdateLabelRequestby value.AutolinkOptionstoCreateAutolinkRequest,AddAutolinktoCreateAutolink, and pass the body by value (#4399)BREAKING CHANGE:
AutolinkOptionsis nowCreateAutolinkRequestwith non-pointerKeyPrefixandURLTemplate;RepositoriesService.AddAutolinkis nowCreateAutolinkand passesbodyby value.IssueRequestintoCreateIssueRequest&UpdateIssueRequestand pass by value (#4396)BREAKING CHANGE:
IssueService.Editis renamed toIssueService.Update.NewPullRequesttoCreatePullRequestand pass it by value (#4395)BREAKING CHANGE:
NewPullRequestis renamed toCreatePullRequest,PullRequests.Createnow takes it by value, andCreatePullRequest.HeadandCreatePullRequest.Baseare nowstring.SarifAnalysisby value (#4394)BREAKING CHANGE:
CodeScanningService.UploadSarifnow takesbodyby value and its required fields are no longer pointers.CreateDeploymentBranchPolicyRequestandUpdateDeploymentBranchPolicyRequestby value (#4382)BREAKING CHANGE:
RepositoriesService.CreateDeploymentBranchPolicyandUpdateDeploymentBranchPolicynow takebodyby value and the requiredNamefield is of typestring.TemplateRepoRequestby value inRepositories.CreateFromTemplate(#4378)BREAKING CHANGE:
RepositoriesService.CreateFromTemplatenow passesbodyby value andNameis now required and passed by value.RepositoryMergeRequestandRepoMergeUpstreamRequestby value (#4372)BREAKING CHANGE:
RepositoriesService.MergeandRepositoriesService.MergeUpstreamnow passbodyby value and required struct fields are now values.BREAKING CHANGE:
DependabotServicemethods involving secrets have new params and return values....and the following additional changes:
MetaService.ListAPIVersions(#4422)DeleteCodeQLDatabasefor code scanning (#4421)Stackfield toPullRequestfor stacked pull requests (#4423)search_typesupport to issue search (#4414)v89.0.0Compare Source
This release contains the following breaking API changes:
DeploymentRequestandDeploymentStatusRequestby value (#4361)BREAKING CHANGE:
CreateDeploymentandCreateDeploymentStatusnow takeDeploymentRequestandDeploymentStatusRequestby value;DeploymentRequest.RefandDeploymentStatusRequest.Stateare nowstring, andDeploymentRequest.RequiredContextsis now[]string.HookConfigby value and renameEditHookConfigurationtoUpdateHookConfiguration(#4360)BREAKING CHANGE:
EditHookConfigurationis renamed toUpdateHookConfigurationonRepositoriesServiceandOrganizationsService; these methods andAppsService.UpdateHookConfignow takeHookConfigby value.OIDCSubjectClaimCustomTemplateby value in the OIDC subject-claim Set methods (#4340)BREAKING CHANGE:
SetOrgOIDCSubjectClaimCustomTemplateandSetRepoOIDCSubjectClaimCustomTemplatenow take theirbodyparams by value.BREAKING CHANGE:
ActionsServicemethods involving variables have new params and return values.BREAKING CHANGE:
ActionsServicemethods involving secrets have new params and return values.CreateJITConfigRequestby value and renameGenerate*JITConfigtoCreate*JITConfig(#4337)BREAKING CHANGE: the JIT config methods are renamed from
Generate*JITConfigtoCreate*JITConfig, and they now takeCreateJITConfigRequest(renamed fromGenerateJITConfigRequest) by value instead of by pointer.EditReleaseAssettoUpdateReleaseAsset(#4336)BREAKING CHANGE:
GenerateReleaseNotesnow takesGenerateNotesRequestby value (renamed fromGenerateNotesOptions);EditReleaseAssetis renamed toUpdateReleaseAssetand takesUpdateReleaseAssetRequestby value.EditReleasetoUpdateRelease(#4329)BREAKING CHANGE:
CreateRelease&UpdateReleasenow takeRepositoryReleaseby value;EditReleaseis renamed toUpdateRelease.GistsServicerequired params by value (#4320)BREAKING CHANGE:
GistsServicemethods now pass required params by-value instead of by-ref.BREAKING CHANGE:
UpdateProvisionedOrgMembershipandUpdateAttributeForSCIMUserparams and return values changed.LicenseStatusresponse andSupportkeytype (#4297)BREAKING CHANGE:
LicenseStatus.SupportKeytype changed from*stringto*boolandLicensereturn type is no longer a slice.BREAKING CHANGE:
SelectedRepositoryIDs []int64is nowRepositories []stringin*AppInstallationRepositoriesOptions....and the following additional changes:
AccessSourcetoTeam(#4344)CONTRIBUTING.md(#4341)organdorg_idcan be an array (#4333)openapi_operations.yaml(#4331)time.DatewithreferenceTime(#4325)ProjectV2Item.UnmarshalJSON(#4323)GetBodyon uploads for HTTP/2 retry (#4318)AbuseRateLimitError.Is(#4292)&xvariables with inlinePtr(value)calls (#4289)GetOrgAICreditUsageandGetUserAICreditUsageendpoints (#4282)testJSONBodyhelper for request body assertions (#4283)Repository(#4268)RequiredReviewerunmarshal (#4270)openapi_operations.yaml(#4265)extraneousnewlinter to catch unnecessary use of value var (#4249)Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.