Skip to content

fix(server): answer boolean questions per question, not per character #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshita-singh12 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(server): answer boolean questions per question, not per character #678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions backend/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,19 +226,18 @@ def get_answer():

@app.route("/get_boolean_answer", methods=["POST"])
def get_boolean_answer():
"""POST /get_boolean_answer - returns "True"/"False" for each yes/no question via the NLI model."""
data = request.get_json()
input_text = data.get("input_text", "")
input_questions = data.get("input_question", [])
output = []

for question in input_questions:
qa_response = answer.predict_boolean_answer(
{"input_text": input_text, "input_question": question}
)
if(qa_response):
output.append("True")
else:
output.append("False")
# predict_boolean_answer expects the full list of questions; passing one
# question at a time made it iterate over the string's characters, and
# checking the returned (always non-empty) list made every answer "True".
answers = answer.predict_boolean_answer(
{"input_text": input_text, "input_question": input_questions}
)
output = ["True" if answer else "False" for answer in answers]

return jsonify({"output": output})

Expand Down