[FMV] Add support-level table and remove __ARM_ACLE_VERSION#441
[FMV] Add support-level table and remove __ARM_ACLE_VERSION#441CarolineConcatto wants to merge 1 commit into
Conversation
CarolineConcatto
requested review from
AlfieRichardsArm,
Lukacma,
labrinea,
mgabka,
paulwalker-arm and
rockdreamer
| `__ARM_ACLE` is defined to `1` to indicate that the implementation | ||
| supports the Arm C Language Extensions. |
There was a problem hiding this comment.
For all macros that we are keeping we need to maintain their original value. From the new specification's point of view we just want to say __ARM_ACLE is defined when an implementation supports the ACLE, we just no longer say what it is defined to.
Existing implementation will maintain their current value in order to not break existing code. New implementation can choose whether they care about legacy code or not.
| Each new set of Function Multi Versioning target version names added | ||
| is assigned a new support level. The new support level is one greater | ||
| than the greatest support level already listed. All target version names | ||
| added in the same set use the same support level. |
There was a problem hiding this comment.
Perhaps worth being explicit and stating a support level includes all the features of earlier support levels unless specifically documented otherwise.
CarolineConcatto
force-pushed
the
deprecate_release
branch
2 times, most recently
from
7ef1436 to
cca2b87
Compare
| C implementation namespace and begin with double underscores. It is | ||
| unspecified whether they are available without the header being | ||
| included. When `__ARM_ACLE` is defined to `1`, the header file is | ||
| included. When `__ARM_ACLE` is defined the header file is |
There was a problem hiding this comment.
I am not sure if we should also change that to remove the reference to 1.
I removed, but now thinking maybe I should leave as it was .
There was a problem hiding this comment.
I've returned to the original text.
Remove __ARM_ACLE_VERSION, change __ARM_ACLE to represent when the header is available, and update __FUNCTION_MULTI_VERSIONING_SUPPORT_LEVEL so that it refers to a new Function Multi Versioning feature availability table. For backwards compatibility with previous features, the table lists the support level at which each current FMV target version name became available. It also defines how future FMV feature sets allocate new support levels.
CarolineConcatto
force-pushed
the
deprecate_release
branch
from
cca2b87 to
09869aa
Compare
3 participants
Remove __ARM_ACLE_VERSION, change __ARM_ACLE to represent when the header is available, and update __FUNCTION_MULTI_VERSIONING_SUPPORT_LEVEL so that it refers to a new Function Multi Versioning feature availability table.
For backwards compatibility with previous features, the table lists the support level at which each current FMV target version name became available. It also defines how future FMV feature sets allocate new support levels.
name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.
Thank you for submitting a pull request!
If this PR is about a bugfix:
Please use the bugfix label and make sure to go through the checklist below.
If this PR is about a proposal:
We are looking forward to evaluate your proposal, and if possible to
make it part of the Arm C Language Extension (ACLE) specifications.
We would like to encourage you reading through the contribution
guidelines, in particular the section on submitting
a proposal.
Please use the proposal label.
As for any pull request, please make sure to go through the below
checklist.
Checklist: (mark with
Xthose which apply)PR (do not bother creating the issue if all you want to do is
fixing the bug yourself).
SPDX-FileCopyrightTextlines on topof any file I have edited. Format is
SPDX-FileCopyrightText: Copyright {year} {entity or name} <{contact informations}>(Please update existing copyright lines if applicable. You can
specify year ranges with hyphen , as in
2017-2019, and usecommas to separate gaps, as in
2018-2020, 2022).Copyrightsection of the sources of thespecification I have edited (this will show up in the text
rendered in the PDF and other output format supported). The
format is the same described in the previous item.
tricky to set up on non-*nix machines). The sequence can be
found in the contribution
guidelines. Don't
worry if you cannot run these scripts on your machine, your
patch will be automatically checked in the Actions of the pull
request.
introduced in this PR in the section Changes for next
release of the section Change Control/Document history
of the document. Create Changes for next release if it does
not exist. Notice that changes that are not modifying the
content and rendering of the specifications (both HTML and PDF)
do not need to be listed.
correctness of the result in the PDF output (please refer to the
instructions on how to build the PDFs
locally).
draftversionis set totruein the YAML headerof the sources of the specifications I have modified.
in the README page of the project.