Skip to content

App layer: duplicated key handling and Quick Look logic; settings folder lists grow unbounded #46

Closed

Description

@dowjames

Findings from the review of Sources/DigUpApp, plus requested UX changes:

  • The panel and the search window each carried near-identical key handlers (Esc/arrows/↩/Space/⌘Y/⌘C, input-method and modifier-mask normalization) and verbatim-duplicated Quick Look toggle/update/data-source code — already drifting apart
  • SearchWindow.show(query:kind:) set filter then query, firing two search runs
  • AppController.setExcluded saved raw paths while applyFolders normalized through FolderSelection — two save paths, different results
  • Onboarding.init ran filesystem scans synchronously on the main thread
  • The Folders to search and Code folders lists grew the settings page without bound

Fixed by #39 (shared KeyCommands / QuickLookController, single-run show, normalized setExcluded, cached Onboarding scans, four-row scrollable folder lists).

Activity

  1. ARahim3 commented on Oct 21, 2026

    @ARahim3
    Owner

    Thanks @dowjames. The folder lists were #17 and are fixed in 0.6.1 (Settings scrolls past the screen now). The shared key handling is a refactor I'm not going to take on right now; the code works and the two surfaces are tested by hand. I'll look at the two save paths for excluded folders. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions