Repository navigation
Add Database Migration Verification and CI Health Check Script Enhancements - #479
Merged
Cjay-Cyber-2 merged 5 commits intoOct 22, 2026
Merged
Conversation
…ssifier The verification script classified statements line by line and read the table and index names from the masked statement, so a quoted identifier was never recognised: the advisory for an index built without CONCURRENTLY never fired, and an indented ALTER TABLE was not matched at all. - analyse every statement as a whole (multi-line statements and leading whitespace included) and read the object names from the unmasked text - reject destructive statements unless the migration opts in with '-- astroid:allow-destructive <reason>'; a migration that is already merged cannot be changed any more and is only reported as a warning - reject ADD COLUMN ... NOT NULL without DEFAULT, which fails as soon as the table holds rows - enforce the CREATE INDEX CONCURRENTLY rules of docs/concurrent-indexes.md - reject leftovers of an interrupted merge and unresolved conflict markers in a migration folder
The suite still expected destructive statements to be a warning. It now covers the forbidden, destructive and unsafe statement checks, the explicit opt-in, the concurrent index rules and the merge artefacts of a migration folder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #406
Closes #407
Closes #408
Closes #410