feat(core): honor schema-level nullable:true in OpenAPI 3.0#83
Open
halotukozak wants to merge 3 commits into
Open
feat(core): honor schema-level nullable:true in OpenAPI 3.0#83halotukozak wants to merge 3 commits into
halotukozak wants to merge 3 commits into
Conversation
Coverage Report
|
Property nullability was derived solely from the parent's required set, so a required property marked nullable:true was generated as a non-nullable Kotlin type. The parser now treats a property as nullable when it is absent from required OR the schema sets nullable:true. The allOf merge preserves schema-level nullability when recomputing against the union of required sets. Closes #41 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
halotukozak
force-pushed
the
feat/41-schema-nullable
branch
from
10c3893 to
a4396eb
Compare
…able # Conflicts: # core/src/main/kotlin/com/avsystem/justworks/core/parser/SpecParser.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
OpenAPI 3.0
nullable: truewas ignored — nullability came only from the parent'srequiredset. A property that isrequiredandnullable: truewas generated as a non-nullable Kotlin type, which is incorrect.SpecParser.propertyModelsnow setsnullable = propName !in required || propSchema.nullable == true.allOfmerge preserves schema-level nullability when recomputing against the union of required sets (prop.name !in required || prop.nullable).Tests
Covers the four combinations on a plain object schema:
nullable:true→ nullablenullable:true→ nullableNotes
OpenAPI 3.1 nullability (type arrays /
nullintype) is out of scope — this addresses the 3.0nullablekeyword.allOf+nullableordering edge cases (a property declared in one member, marked required in a later member) are rare and handled best-effort via the OR.Closes #41
🤖 Generated with Claude Code