Update Frogger and fix a chatlog issue - #452
Open
mcdemarco wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frogger's refills variant now uses the sequenced turn model instead of a full-round passing mechanism. This change is applied based on version so shouldn't affect games in progress.
Several unrelated bugs in Frogger surfaced during testing and were fixed.
An issue arose with GameBase.chatLog() (_base.ts) misidentifying players, which was fixed by resolving each ply's actor via plyActor() instead of currplayer - 1. You might want to review that, but I'm really submitting this as a PR because I will be AFK for a week and cannot easily fix or revert anything that goes wrong, though I can test it on the dev server whenever you're ready to roll it out.