Repository navigation
feat: SG-45327: jxl cmake support via oiio - #1419
shanesmith-dwa wants to merge 2 commits into
Conversation
Assisted-by: copilot / opus 4.8 Signed-off-by: Shane Smith <shane.smith@dreamworks.com>
22b0691 to
74a6c7f
Compare
|
Hi @shanesmith-dwa, thank you for participating in the dev days! We are tracking this PR and the other PRs you've created. The testing might take some time, but we should be able to review them sooner. Thank you for the contribution! |
| # JPEG XL support is optional: set JXL_ROOT to a pre-installed library to enable. | ||
| SET(JXL_ROOT | ||
| "" | ||
| CACHE PATH "Root of a pre-installed jxl library used by OpenImageIO" | ||
| ) | ||
|
|
There was a problem hiding this comment.
This can be removed once the dependencies matches the other similar dependencies.
|
The main concern is that this doe not follow how the other dependencies are wired, and I'd like to see it brought in line before we merge. Make libjxl a managed dependency
I realised that build JXL from source is more work, but that's the current flow we want for the dependencies. |
Assisted-by: copilot / opus 4.8 Signed-off-by: Shane Smith <shane.smith@dreamworks.com>
|
Thanks @cedrik-fuoco-adsk. I have refactored the PR to address the move from an optional dependency to a managed dependency. I do have some follow up questions.
|
Summarize your change.
CMake changes assuming that libjxl is preinstalled and forwards the library on to be built with OpenImageIO.
Assisted-by: Copilot / Opus 4.8
Describe the reason for the change.
To support the JPEG XL image format
Describe what you have tested and on which operating system.
Reading in a jxl file. Successfully tested on Rocky Linux 9.7
Add a list of changes, and note any that might need special attention during the review.
CMake requires that JXL_ROOT provide the path to libjxl. libjxl v0.11.1 tested
jxl.cmake maintains the existing header structure i.e.
Copyright (C) 2026 Autodesk, Inc. All Rights Reserved.
Should the copyright holder be updated / omitted?