fix(ci): propagate retried build failures - #1406
Conversation
Greptile SummaryThis PR makes the retried Tauri build command fail immediately when any setup, installation, or build command returns nonzero.
Confidence Score: 5/5The PR appears safe to merge because the new errexit behavior correctly propagates failed build commands across the release matrix. The activation fallback remains valid as an Important Files Changed
Reviews (1): Last reviewed commit: "fix(ci): propagate retried build failure..." | Re-trigger Greptile |
|
Greptile is 5/5 and the affected macOS Intel Tauri build passed. The remaining Windows and Qt matrix jobs are still running, so there is no additional fix to make yet; waiting for CI completion and maintainer review. |
Problem
The Tauri build uses nick-fields/retry with a custom Bash command that did not enable fail-fast behavior. When make build failed, the trailing pip freeze returned zero, so the retry action treated a partial build as successful.
This happened in the macOS Intel job of TimeToBuildBob/activitywatch run 32205310837: aw-tauri failed before the root Makefile restored the local aw-client checkout, pip freeze showed aw-client 0.5.14, and the next step ran checkout tests against that stale installed package.
Fix
Enable Bash errexit inside the retried Build command. A failed install or build now reaches the retry action immediately, and tests only run after the complete build path succeeds.
I deliberately kept the aw-client tests unchanged: switching them to force source imports would silence this useful packaging-environment canary.
Verification