build(ci): upgrade tauri-apps/tauri-action to v1 - #239
Conversation
Upgrades tauri-action from v0 to v1 across build and release workflows. Also renames `includeUpdaterJson` to `uploadUpdaterJson` per the v1 API change — the old name would be silently ignored, breaking updater JSON upload for signed builds. Supersedes dependabot PR ActivityWatch#230 which bumped the version but missed the parameter rename.
Greptile SummaryThe PR completes the tauri-action v1 migration and adjusts release behavior for compatibility.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the current configuration reuses existing published releases and resolves the previously reported rerun failure. Important Files Changed
Reviews (2): Last reviewed commit: "fix(ci): set releaseDraft: false to avoi..." | Re-trigger Greptile |
|
|
||
| - name: Build the app | ||
| uses: tauri-apps/tauri-action@v0 | ||
| uses: tauri-apps/tauri-action@v1 |
There was a problem hiding this comment.
|
Addressing the Greptile 4/5 finding on The concern is valid — tauri-action v1 enforces that However, the alternative ( The practical mitigation: if any matrix job fails, rerun it before manually publishing the draft. This keeps the normal workflow intact and avoids the edge case. Given that rerunning against an already-published release isn't part of the standard release process here, this limitation is acceptable. If this becomes a real pain point in practice, the fix would be to split the workflow into two phases: a build phase that uploads artifacts to a staging area, and a separate publish step that only creates/updates the GitHub release — but that's a larger rework for another day. |
…cement tauri-action v1 enforces that releaseDraft: true invocations can only attach assets to a draft release. With matrix builds, if any job fails after the draft has been published, reruns fail. Setting releaseDraft: false releases immediately on tag push, avoiding this edge case.
|
@greptileai review |
|
Greptile re-reviewed at 5/5 and all CI checks are green. Ready for maintainer merge. |
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
Upgrades
tauri-apps/tauri-actionfrom v0 to v1 acrossbuild.ymlandrelease.yml, and fixes a breaking-change parameter rename inrelease.yml.Changes
build.yml:tauri-action@v0→tauri-action@v1release.yml:tauri-action@v0→tauri-action@v1,includeUpdaterJson→uploadUpdaterJsonWhy the parameter rename matters
includeUpdaterJsonwas renamed touploadUpdaterJsonin v1 (changelog). Without this fix, the old name is silently ignored and updater JSON is never uploaded for signed builds, breaking auto-update functionality.Relation to #230
Dependabot PR #230 bumped the version pin but missed the parameter rename. This PR supersedes it with the complete migration.