Skip to content

build(ci): upgrade tauri-apps/tauri-action to v1 - #239

Open
TimeToBuildBob wants to merge 2 commits into
ActivityWatch:masterfrom
TimeToBuildBob:fix/tauri-action-v1-migration
Open

build(ci): upgrade tauri-apps/tauri-action to v1#239
TimeToBuildBob wants to merge 2 commits into
ActivityWatch:masterfrom
TimeToBuildBob:fix/tauri-action-v1-migration

Conversation

@TimeToBuildBob

Copy link
Copy Markdown
Contributor

Upgrades tauri-apps/tauri-action from v0 to v1 across build.yml and release.yml, and fixes a breaking-change parameter rename in release.yml.

Changes

  • build.yml: tauri-action@v0tauri-action@v1
  • release.yml: tauri-action@v0tauri-action@v1, includeUpdaterJsonuploadUpdaterJson

Why the parameter rename matters

includeUpdaterJson was renamed to uploadUpdaterJson in v1 (changelog). Without this fix, the old name is silently ignored and updater JSON is never uploaded for signed builds, breaking auto-update functionality.

Relation to #230

Dependabot PR #230 bumped the version pin but missed the parameter rename. This PR supersedes it with the complete migration.

Upgrades tauri-action from v0 to v1 across build and release workflows.
Also renames `includeUpdaterJson` to `uploadUpdaterJson` per the v1 API
change — the old name would be silently ignored, breaking updater JSON
upload for signed builds.

Supersedes dependabot PR ActivityWatch#230 which bumped the version but missed the
parameter rename.
@greptile-apps

greptile-apps Bot commented Aug 18, 2026

Copy link
Copy Markdown

Greptile Summary

The PR completes the tauri-action v1 migration and adjusts release behavior for compatibility.

  • Upgrades tauri-apps/tauri-action from v0 to v1 in build and release workflows.
  • Renames includeUpdaterJson to the v1-compatible uploadUpdaterJson input.
  • Sets releases to non-draft so reruns can reuse already-published releases.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains; the current configuration reuses existing published releases and resolves the previously reported rerun failure.

Important Files Changed

Filename Overview
.github/workflows/build.yml Upgrades the build step to tauri-action v1 without changing its existing inputs or build flow.
.github/workflows/release.yml Completes the v1 input migration and fixes the previously reported published-release rerun failure by setting releaseDraft to false.

Reviews (2): Last reviewed commit: "fix(ci): set releaseDraft: false to avoi..." | Re-trigger Greptile


- name: Build the app
uses: tauri-apps/tauri-action@v0
uses: tauri-apps/tauri-action@v1

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Published release reruns fail

When this workflow is rerun or manually dispatched for a tag whose release is already published, tauri-action v1 rejects that release because releaseDraft is true and then attempts to create a duplicate, causing the release workflow to fail.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Addressing the Greptile 4/5 finding on releaseDraft: true:

The concern is valid — tauri-action v1 enforces that releaseDraft: true invocations can only attach assets to a draft release, not a published one. This means reruns of failed matrix jobs would break if the draft had already been published.

However, the alternative (releaseDraft: false) auto-publishes immediately, removing the draft-review window that lets maintainers verify assets before making the release public.

The practical mitigation: if any matrix job fails, rerun it before manually publishing the draft. This keeps the normal workflow intact and avoids the edge case. Given that rerunning against an already-published release isn't part of the standard release process here, this limitation is acceptable.

If this becomes a real pain point in practice, the fix would be to split the workflow into two phases: a build phase that uploads artifacts to a staging area, and a separate publish step that only creates/updates the GitHub release — but that's a larger rework for another day.

…cement

tauri-action v1 enforces that releaseDraft: true invocations can only
attach assets to a draft release. With matrix builds, if any job fails
after the draft has been published, reruns fail. Setting releaseDraft: false
releases immediately on tag push, avoiding this edge case.
@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

@greptileai review

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

Greptile re-reviewed at 5/5 and all CI checks are green. Ready for maintainer merge.

@TimeToBuildBob

Copy link
Copy Markdown
Contributor Author

CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click.

This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant