feat(updater): add updater signing pubkey, build updater artifacts when key present - #240
Conversation
…en key present - Set the updater plugin pubkey (private key + password live in CI secrets TAURI_SIGNING_PRIVATE_KEY / TAURI_SIGNING_PRIVATE_KEY_PASSWORD on ActivityWatch/activitywatch) - Enable bundle.createUpdaterArtifacts via --config only when TAURI_SIGNING_PRIVATE_KEY is set, so local builds and fork PRs (no secrets) still build plain bundles instead of failing on a missing key
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Greptile SummaryThe PR configures the updater verification public key and makes updater artifact generation conditional on the signing key being available.
Confidence Score: 5/5The PR appears safe to merge with no concrete blocking or independently actionable non-blocking issue identified. The signing-dependent build override preserves ordinary builds without secrets, while the updater configuration supplies the public key required to verify signed release artifacts. Important Files Changed
Reviews (1): Last reviewed commit: "feat(updater): add updater signing pubke..." | Re-trigger Greptile |
Part of the updater-prerequisite work for ActivityWatch/activitywatch#1372 (see prerequisites in that PR's description) and #68.
Changes
plugins.updater.pubkeyto the new ActivityWatch updater signing public key. The matching private key + password are now configured asTAURI_SIGNING_PRIVATE_KEY/TAURI_SIGNING_PRIVATE_KEY_PASSWORDActions secrets on ActivityWatch/activitywatch (where release builds run), and the key material is backed up offline.bundle.createUpdaterArtifactsconditionally via--configin the Makefile, only whenTAURI_SIGNING_PRIVATE_KEYis set. CommittingcreateUpdaterArtifacts: truedirectly would make everytauri buildfail without the signing key, breaking local builds and fork PRs (no secrets). With this approach, release CI (which has the secret) emits updater bundles +.sigfiles, while everything else builds plain bundles as before.Notes
latest.json). The research-edition endpoint split from ci(release): publish Tauri updater latest.json on tag releases activitywatch#1372 still needs its own handling here — deferring that to @0xbrayo's release-line design.