Feat/port agent runner changes - #163
Conversation
| try | ||
| { | ||
| try | ||
| while (thread.IsAlive) |
There was a problem hiding this comment.
In the original code, there was an IsClosed check which is now gone.
There was a problem hiding this comment.
The isClosed check has been moved to line 195. This matches the 2.5.0 AgentRunner behaviour.
There was a problem hiding this comment.
The code for the close in Java looks different. I would really keep it as close at that implementation.
There was a problem hiding this comment.
I think I should dig into Agrona .NET.
91728de to
730ee3c
Compare
|
Discussed PR comments with @pveentjer offline and resolved the comments around the faithfulness of the port. The main concern, that the Dispose loop could cause an infinite loop, is behaviour from upstream, and we've agreed that is where the discussion for this will take place. Until upstream's behaviour changes again, this port will be Agrona.NET's behaviour going forward. |
2 participants
No description provided.