fix: the repo-root README was outside every gate, and seven releases stale - #120
Merged
Merged
Conversation
…stale `README.md:18` advertised CLI `0.8.11` against a `0.15.0` pin, and line 19 claimed scaffolds emit `fluidVersion: 0.7.4`. This is the first thing a GitHub visitor reads. **It was unreachable by the checker on two separate counts**, which is why it survived a 149-agent audit and five merged clusters: 1. The sweep iterates `_iter_doc_files(DOCS_DIR)` — everything under `docs/`. The root README is not under `docs/`, so no pattern was ever applied to it. 2. Even once included, the "CLI release bullet" pattern required the version to follow `CLI release` immediately. The README writes "Current CLI release **documented here:** `0.8.11`", and the interposed words defeated the match. Both are fixed, and I only found the second because the first did not work: after widening the file sweep I seeded the stale value back and the gate stayed green. A fix that is not canary-tested is a guess. The canary now behaves correctly — seeding `0.8.11` produces `README.md:18: CLI release bullet says CLI 0.8.11, pin is 0.15.0`, and restoring it exits 0. `cli-consistency.yml` gains `README.md` to its path filter, so editing that file actually runs the job that now checks it. A gate that cannot be triggered by the file it guards is the same defect in a different place.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
README.md:18advertised CLI0.8.11against a0.15.0pin, and line 19 claimed scaffolds emitfluidVersion: 0.7.4. This is the first thing a GitHub visitor reads.It was unreachable by the checker on two separate counts
Which is why it survived a 149-agent audit and five merged clusters:
_iter_doc_files(DOCS_DIR)— everything underdocs/. The root README is not underdocs/, so no pattern was ever applied to it.CLI release bulletpattern required the version to followCLI releaseimmediately:0.8.11" — the interposed words defeat the match.I only found the second because the first didn't work
After widening the file sweep I seeded the stale value back and the gate stayed green. A fix that isn't canary-tested is a guess.
The canary now behaves correctly:
And the gate now runs when that file changes
cli-consistency.ymlgainsREADME.mdto its path filter. A gate that cannot be triggered by the file it guards is the same defect in a different place.