Skip to content

Extract the repeated fees check into a shared helper #295

Closed
Feature
#434
Closed
Extract the repeated fees check into a shared helper#295
Feature
#434
Assignees
Jagadeeshftw
Labels
GRANTFOX OSSGrantFox open-source campaign taskMAYBE REWARDEDMay be rewarded under the GrantFox campaignOFFICIAL CAMPAIGNOfficial GrantFox campaign issueOfficial Campaign | FWC26GrantFox FWC26 official campaignarea:feesfeespriority:mediumMedium prioritystack:rustRuststack:sorobanSoroban smart contracttype:refactorRefactor without behavior change

Description

@mikewheeleer
mikewheeleer
opened on Jul 23, 2026

Deduplicate fees checks

Description

Multiple entrypoints repeat the same fees precondition inline. This issue extracts a shared helper.

Requirements and context

  • Repository scope: Agentpay-Org/Agentpay-contracts only.
  • Extract the repeated fees check into a private helper and route entrypoints through it.
  • Behaviour unchanged; same rejections and typed codes.
  • No ABI change.

Suggested execution

  • Fork the repo and create a branch
  • git checkout -b refactor/fees-01-helper
  • Implement changes
    • Write code in: the relevant module.
    • Write comprehensive tests in: cover the new behaviour and edge cases.
  • Test and commit

Test and commit

  • Run cargo fmt, cargo clippy --all-targets -- -D warnings, and cargo test.
  • Cover edge cases: each existing rejection still fires identically.
  • Include the full test output in the PR description.

Example commit message

refactor(fees): extract shared check helper

Guidelines

  • Minimum 95 percent test coverage for impacted modules.
  • Clear, reviewer-focused documentation.
  • Timeframe: 96 hours.

Community & contribution rewards

  • 💬 Join the AgentPay community on Discord: https://discord.gg/eXvRKkgcv
  • ⭐ This is a GrantFox OSS / Official Campaign task and may be rewarded. When your PR is merged you'll be prompted to rate the project — a 5-star rating is much appreciated.

Activity

  1. mikewheeleer
    added
    GRANTFOX OSSGrantFox open-source campaign task
    MAYBE REWARDEDMay be rewarded under the GrantFox campaign
    OFFICIAL CAMPAIGNOfficial GrantFox campaign issue
    on Jul 23, 2026
  2. mikewheeleer
    added the
    Feature
    issue type on Jul 23, 2026
  3. mikewheeleer
    added
    priority:mediumMedium priority
    stack:rustRust
    stack:sorobanSoroban smart contract
    type:refactorRefactor without behavior change
    Official Campaign | FWC26GrantFox FWC26 official campaign
    area:feesfees
    on Jul 23, 2026
  4. mikewheeleer
    closed this as not plannedon Jul 26, 2026
  5. mikewheeleer
    reopened this on Jul 26, 2026

  6. Jagadeeshftw commented on Jul 28, 2026

    @Jagadeeshftw
    Jagadeeshftw
    on Jul 28, 2026
    Contributor

    Hi, I’d love to take on this issue! With my expertise in Rust, Stellar, and smart contract development, I can implement a clean and efficient solution.

    🚀 Why Me?

    • Proven Blockchain Experience – Hands-on work with Stellar, Solidity, and Rust, building secure and optimized smart contracts.
    • Open Source Contributor – Actively contributed to 50+ open-source projects, showcasing adaptability and collaboration.
    • Efficient & Reliable – I deliver high-quality, production-ready solutions quickly, ensuring security and scalability.

    ⏱ Timeline

    I estimate completing this within 24 hours. Let me know if I can proceed!

  7. mikewheeleer
    assigned
    Jagadeeshftw
    on Jul 28, 2026

  8. grantfox-oss commented on Jul 28, 2026

    @grantfox-oss
    grantfox-ossBot
    on Jul 28, 2026 – with GrantFox OSS

    🦊 GrantFox — @Jagadeeshftw has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

    Next steps:

    1. Open a Pull Request referencing this issue (e.g., Closes #295)
    2. Your PR will be reviewed by the Agentpay-Org maintainers

    Good luck! Track your progress on GrantFox.

  9. mikewheeleer commented on Jul 28, 2026

    @mikewheeleer
    mikewheeleer
    on Jul 28, 2026
    ContributorAuthor

    🎉 You're assigned, @Jagadeeshftw! Part of the Stellar Wave Program — join our Telegram to coordinate: https://t.me/+OhR36aTevMYwYzI9 🚀

  10. grantfox-oss commented on Jul 29, 2026

    @grantfox-oss
    grantfox-ossBot
    on Jul 29, 2026 – with GrantFox OSS

    🎉 This issue has been marked as completed on GrantFox as part of the Official Campaign | FWC26 campaign!

    @Jagadeeshftw's PR #434 was approved and merged by @mikewheeleer.

    🏆 @Jagadeeshftw: You earned 45 FoxPoints for this contribution! Your current tier: Specialist (3,806 total points). Track your full progress on GrantFox.

    👏 Great work, @Jagadeeshftw! Keep contributing to Agentpay-Org.

  11. mikewheeleer
    closed this as completedin #434on Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

GRANTFOX OSSGrantFox open-source campaign taskMAYBE REWARDEDMay be rewarded under the GrantFox campaignOFFICIAL CAMPAIGNOfficial GrantFox campaign issueOfficial Campaign | FWC26GrantFox FWC26 official campaignarea:feesfeespriority:mediumMedium prioritystack:rustRuststack:sorobanSoroban smart contracttype:refactorRefactor without behavior change

Type

Feature

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions