Repository navigation
Conversation
The WebSocket reader now records the close frame (code and reason) or the transport error, and the types of Astation messages it couldn't parse (dropped before, silently). 'atem pair' adds both to the error when the connection closes while it waits for Astation's reply. 🤖 Built with SMT <smt@agora.build>
Contributor
Author
|
Dropped: under the approved session-multiplexing design, Generated with SMT smt@agora.build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
atem pairfailed with "Astation connection closed during device verification" after the safety codes matched, with no way to tell why: the WebSocket reader dropped the close frame's reason and silently dropped any Astation message it couldn't parse.typeof each message that didn't parse (never its content; at most 8 per socket).atem pairappends both to the error, e.g.Astation connection closed during device verification (closed by Astation: 1008 "signing failed"; unreadable messages from Astation: deviceVerified).Heartbeats were considered and left out: Atem doesn't send them anywhere today, and long-lived TUI connections stay up, so an idle close is unlikely.
Testing
deviceVerifiedthen closes with 1008 "signing failed"; the error names both.cargo test: 1266 unit + agent_launch_binary 3, key_agent_binary 2, terminal_ui_binary 2, all pass. Clippy: no new warnings.Generated with SMT smt@agora.build