Repository navigation
feat(runtime): log refused session, terminal and chat requests - #77
Merged
Merged
Conversation
Every inbound session-v1, terminal-v1 or chat-v1 request answered with an error (or a rejected receipt), plus oversize and full-inbox drops, gets one line: `refused <family>/<op>[ kind=<kind>] <code>[ session=<sid>][ (<reason>)]`. Never content: ops outside the protocol vocabulary show as `?`, decode failures keep only the serde category and field name. At most 20 lines per 10 s per link, then one "… N more refusals suppressed" line. 🤖 Built with SMT <smt@agora.build>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logs every refused session-family request to runtime.log:
HH:MM:SS atem runtime: refused <family>/<op>[ kind=<kind>] <code>[ session=<sid>][ (<reason>)].busy.Motivation: in the live test, Astation's rule Revoke never took effect, and Atem left no trace of whether the request arrived, failed to decode or was refused.
Tests: unit and runtime tests, including a check that a planted marker value never appears in any line. Full
cargo testpassed twice (1669 unit tests plus every binary suite),runtime_fixtures_binarypassed 3/3, and clippy has no new warnings.Generated with SMT smt@agora.build