Skip to content

Correct the test counts in the README - #2

Merged
guohai merged 1 commit into
mainfrom
docs/test-counts
Sep 10, 2026
Merged

guohai merged 1 commit into
mainfrom
docs/test-counts

Conversation

@guohai

@guohai guohai commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

The suite is 49 unit and 11 end-to-end tests; the README still claimed 35 and 8
from before the config, multi-shell and regression tests were added.

Generated with SMT smt@agora.build

The suite is 49 unit and 11 end-to-end tests; the README still claimed 35 and 8
from before the config, multi-shell and regression tests were added.

🤖 Built with SMT <smt@agora.build>
@github-actions

Copy link
Copy Markdown

🤖 Codex Code Review

No issues found. The README now accurately reports 49 unit tests and 11 end-to-end tests, matching the test definitions in src/ and tests/tmux_e2e.rs. The change is documentation-only and introduces no security, correctness, performance, or maintainability concerns.

@github-actions

Copy link
Copy Markdown

🤖 Claude Code Review

Verified the claim rather than taking it at face value — counted #[test] attributes across the tree:

File Tests
src/ansi.rs 6
src/cli.rs 16
src/config.rs 7
src/render.rs 16
src/state.rs 4
unit total 49
tests/tmux_e2e.rs 11

Both new numbers in README.md:192 are exactly right (no #[tokio::test], rstest, or other test-attribute forms in the tree that would shift the count, and no #[ignore]d tests inflating it). I also grepped the rest of the docs for other stale test-count claims — README.md:192 is the only place a count appears, so nothing else needs the same correction.

No concerns in any of the flagged areas: the diff touches one comment line in a fenced code block and no Rust source, no shell hooks, and no capture path. Nothing here affects tmux coordinate arithmetic, $? ordering in precmd, argv handling, or scrollback exposure.

One note on durability rather than correctness: a hardcoded count in prose goes stale on the next test added, and there's no check that fails when it does — this PR is itself the second correction of this line. If it drifts again, dropping the numbers (cargo test # unit + end-to-end tests) removes the maintenance burden entirely. Not a blocker.

Looks good — approve.

@guohai
guohai merged commit b8c193e into main Sep 10, 2026
5 checks passed
@guohai
guohai deleted the docs/test-counts branch September 10, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant