Skip to content

Fix inline spacing for footer Thanks link - #243

Merged
guohai merged 1 commit into
mainfrom
fix/footer-thanks-inline
Oct 5, 2026
Merged

guohai merged 1 commit into
mainfrom
fix/footer-thanks-inline

Conversation

@guohai

@guohai guohai commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

Changes

  • Render the community credit and clickable Thanks! link as one sentence with a normal space instead of a separate flex item and 16px gap.
  • Preserve natural mobile wrapping, existing test IDs, other footer links, and GeoIP notices.
  • Add desktop geometry and mobile text regression coverage.

Validation

  • Targeted ESLint: passed.
  • TypeScript checks for the application and eval agent: passed.
  • Application production build: passed.
  • Focused Thanks-page Playwright suite: 14 tests passed.
  • Required full pre-merge gate: ./scripts/full-tests-run.sh all --verbose passed against the exact PR commit in an isolated runtime and task-owned test database.
  • Unit/integration: 2,534 passed, 45 skipped; audio pipeline: 29 passed; browser suite: 237 passed, 16 skipped.
  • GitHub build and both automated code-review checks passed; no actionable issues found.

Generated with SMT smt@agora.build

Render the community credit and Thanks! link as one paragraph with normal text spacing. Add desktop spacing and mobile text regression coverage.

🤖 Built with SMT <smt@agora.build>
@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🤖 Codex Code Review

No actionable issues found. The change correctly renders the credit and Thanks link as one inline sentence, preserves wrapping and test IDs, and introduces no apparent security, logic, performance, or maintainability regressions.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

🤖 Claude Code Review

This change looks good to merge. I found no security, logic or performance problems.

client/src/components/layout.tsx

  • The credit line and the Thanks link now share one <p>, with an explicit {" "} between them. Before, they were two flex items spaced by gap-x-4, which is why the link sat apart from the sentence. Now the link reads inline and wraps as normal text on narrow screens.
  • The data-testids didn't change, and w-full sm:w-auto stays on the new container, so mobile and desktop alignment work as before.
  • The link text changed from "Thanks" to "Thanks!". Nothing else selects the link by its old label: the other tests look it up by test id, and the "Thanks." heading checks target the page's h1.

tests/e2e/thanks.spec.ts

  • The new geometry check builds a range ending just before the link and takes its last client rect. That rect belongs to the {" "} text node, which uses the primary font, so the emoji earlier in the line doesn't affect the top comparison.
  • The space isn't collapsed because it doesn't end a line. Its width is included in that rect, so thanksBox.x ≈ lastRect.right holds.
  • At 1280px the line doesn't wrap, so the 1px tolerances should be stable.
  • One small weakness: if layout ever left rects empty, lastRect would be undefined and the evaluate call would throw a TypeError instead of failing a clear assertion. That's unlikely here, and the test would still fail either way.

@guohai
guohai merged commit 69b6e44 into main Oct 5, 2026
7 checks passed
@guohai
guohai deleted the fix/footer-thanks-inline branch October 5, 2026 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant