Skip to content

fix(risk-fork): reject malformed qualification binding policy - #490

Merged
rhein1 merged 3 commits into
mainfrom
codex/risk-fork-verified-e2b-handoff-20261007
Oct 9, 2026
Merged

rhein1 merged 3 commits into
mainfrom
codex/risk-fork-verified-e2b-handoff-20261007

Conversation

@rhein1

@rhein1 rhein1 commented Oct 7, 2026 •

Copy link
Copy Markdown
Collaborator

Malformed local expected-binding values now fail before signed E2B evidence verification can accept them. Caller policy is validated independently of external signatures, preventing omitted, empty, or invalid local constraints from widening the accepted qualification contract.

Refreshed against merged #488/current main 1d1d346d81a5c95f73f4a5c40392a1df87600117; generated hosted conflicts were rebuilt canonically. Candidate tree bcecc92c90a77b2dadb69cce9d72e063904d35d5 preserves all previously merged security changes.

Validation: expected-binding regressions6/6 with zero skips; core/hosted syntax checks; hosted source verification; hosted artifact/offline consumer16/16 with zero skips; clean diff. Source review found no blocking issue. Fresh exact-head CI remains required.

This source-only/default-off repair grants no provider authority or live protection. Issues #375, #301, #302 and #303 retain their operational requirements. Publication, spend, deployment and activation remain separately gated.

@rhein1
rhein1 marked this pull request as ready for review October 9, 2026 21:50

@jmborden1112-beep jmborden1112-beep left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Needs Fixing

None found for refreshed head 1078b4d25a53dc2bdc040d8a77ed52353afc5450, tree bcecc92c90a77b2dadb69cce9d72e063904d35d5.

Requires Human Review

None for this authorized source repair. Independent operational qualification remains separate.

Recommended Optional

None.

Create Follow-up Issue

Existing #375/#301/#302/#303 cover remaining production gates.

Malformed expected-binding policy now fails closed before signed qualification acceptance. All five changed files and callers were reviewed; canonical bundle/manifest regeneration retains source-only/default-off authority. Expected-binding6/6 and hosted artifact16/16 pass with zero skips; fresh hosted CI must pass before merge.

Workflow Trace: inherited Codex source/correctness and operations/test reviewers, root final signed-head/tree verification. Authorized second owner-controlled account approval; no third-party certification, provider call, spend, deployment, publication, activation or live protection claim. No protection bypass.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T21:54:07.443829Z 1078b4d Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@rhein1
rhein1 merged commit 1c79aac into main Oct 9, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants