Repository navigation
feat(risk-fork): bind signed adapter artifact identity - #492
Conversation
jmborden1112-beep
left a comment
jmborden1112-beep
left a comment
There was a problem hiding this comment.
LGTM
Needs Fixing
None found at d93c349, tree25eecf1ee8438dcd92d8a2cf5ef04c8ca7c996a1. The final main alignment preserves the independently reviewed tree.
Requires Human Review
Operational qualification remains separate from authorized source merging.
Recommended Optional
None.
Create Follow-up Issue
Existing #375/#301/#302/#303 retain live requirements.
Host-pinned optional adapterArtifactHash is signed before observer verification, captured privately and enforced for current/historical provenance. Substitution or malformed host policy fails closed. The change does not claim loaded-byte or production proof. Fresh source/caller review and50/50 focused tests passed; root44/45 with one Windows ownership skip and canonical integrity6961cdef passed. Every applicable exact-head CI check must pass before merge.
Workflow Trace: actual inherited Codex review contexts plus root canonical regeneration and final tree verification; requested review-profile fallback disclosed. Owner-controlled second-account source review, not third-party operational certification. No provider call/spend/publication/deployment/activation/protection bypass.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bind an optional host-pinned adapter artifact hash into the existing signed qualification evidence before independent observer callbacks. Missing, mismatched or substituted reserved evidence fails closed; current and historical cleanup retain the pin privately. This establishes signed artifact identity, not immutable loaded-byte provenance.
Refreshed after #491 merged, against main bed8b7a. Candidate d93c349, tree25eecf1ee8438dcd92d8a2cf5ef04c8ca7c996a1, seven intended paths. Canonical source integrity6961cdef0530085efdc3419a0df601846ed8e213505d41748d3d7bd7e264ed85.
Fresh review inspected source/callers and preserved the #491 constructor guard and cleanup binding. Focused qualification, binding, cleanup and journal tests50/50 passed; root binding/qualification/cleanup suite44 passed with one expected Windows POSIX skip. Canonical source verification and clean diff passed. All applicable exact-head hosted checks, including Linux/PostgreSQL and fresh artifacts, are required before merge.
Source only. Provider calls remain disabled. No publication, deployment, spend or activation. Existing #375/#301/#302/#303 retain genuine independent operational and production requirements.