Skip to content

feat: documented Storybooks for app + site with CI-enforced coverage - #48

Merged
AhmedFr merged 18 commits into
mainfrom
feat/storybook
Aug 3, 2026
Merged

AhmedFr merged 18 commits into
mainfrom
feat/storybook

Conversation

@AhmedFr

@AhmedFr AhmedFr commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Implements docs/superpowers/specs/2026-07-29-storybook-design-system-design.md

  • Root Storybook (react-vite) for the 32 app components, dark vibrancy-panel decorator, Intro + live Tokens docs
  • Site Storybook (nextjs-vite) for the site components, Tailwind v4 tokens docs
  • stories-coverage.test.ts in both trees: a component folder without stories fails pnpm test (explicit EXEMPT list with reasons)
  • CI: both storybook builds on every PR + new site job (typecheck, tests, storybook)
  • CLAUDE.md: .stories.tsx is now a required member of every component folder

Run locally: pnpm storybook (app, port 6006) and pnpm storybook inside site/ (port 6007).

🤖 Generated with Claude Code

AhmedFr and others added 17 commits July 29, 2026 15:05
pnpm typecheck previously never checked .storybook/main.ts or
.storybook/preview.tsx (only constants.ts was pulled in transitively via
the Toggle story import). Add .storybook/**/* to tsconfig.web.json's
include so a future type error in either file fails typecheck.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds a test that requires every visual component folder to have a *.stories.tsx file, with exemptions only for non-visual/behavioral components (JsonLd, SetHtmlLang, SvgSprite, RevealClient) and server-only page compositions (BlogArticle, BlogIndex, HomePage, LegalPage, PrivacyPage).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Documents the required .stories.tsx per component folder and the
stories-coverage.test.ts EXEMPT-list convention in CLAUDE.md, adds a
Storybook section covering both books and the docs/storybook MDX
convention, updates STATUS.html with the completed roadmap item and
session log, and fixes a pre-existing Biome formatting error in
stories-coverage.test.ts that was failing `biome ci`.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
site/tsconfig.json's include globs never matched the dot-directory
site/.storybook/, so main.ts and preview.ts were silently excluded
from tsc --noEmit. Add .storybook/**/*.ts to include.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Sweep the last em dashes out of story-file comments for consistency
with 07a28a5, which already did this for CookieConsent.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clean-my-node-modules Ready Ready Preview Aug 3, 2026 12:40pm

@coderabbitai

coderabbitai Bot commented Jul 29, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@AhmedFr, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 28 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b22fd76f-8323-4233-96d5-fa81facb2d33

📥 Commits

Reviewing files that changed from the base of the PR and between f42e5b4 and 8225c7d.

⛔ Files ignored due to path filters (2)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
  • site/pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (77)
  • .github/workflows/ci.yml
  • .gitignore
  • .storybook/constants.ts
  • .storybook/main.ts
  • .storybook/mock-clean-api.ts
  • .storybook/preview.tsx
  • .storybook/storybook.css
  • CLAUDE.md
  • STATUS.html
  • docs/storybook/Intro.mdx
  • docs/storybook/Tokens.mdx
  • package.json
  • site/.storybook/main.ts
  • site/.storybook/preview.ts
  • site/components/AppPanel/AppPanel.stories.tsx
  • site/components/Areas/Areas.stories.tsx
  • site/components/Btn/Btn.stories.tsx
  • site/components/CookieConsent/CookieConsent.stories.tsx
  • site/components/CookiePreferences/CookiePreferences.stories.tsx
  • site/components/Download/Download.stories.tsx
  • site/components/Eyebrow/Eyebrow.stories.tsx
  • site/components/FeatureGrid/FeatureGrid.stories.tsx
  • site/components/Features/Features.stories.tsx
  • site/components/FinalCta/FinalCta.stories.tsx
  • site/components/Footer/Footer.stories.tsx
  • site/components/Hero/Hero.stories.tsx
  • site/components/HowItWorks/HowItWorks.stories.tsx
  • site/components/Icon/Icon.stories.tsx
  • site/components/LangSwitcher/LangSwitcher.stories.tsx
  • site/components/LegalArticle/LegalArticle.stories.tsx
  • site/components/Navbar/Navbar.stories.tsx
  • site/components/PixelMeter/PixelMeter.stories.tsx
  • site/components/Pixrow/Pixrow.stories.tsx
  • site/components/SectionHead/SectionHead.stories.tsx
  • site/components/StatementBand/StatementBand.stories.tsx
  • site/components/WhyLifecycle/WhyLifecycle.stories.tsx
  • site/components/Wrap/Wrap.stories.tsx
  • site/components/stories-coverage.test.ts
  • site/components/ui-mock/ui-mock.stories.tsx
  • site/docs/storybook/Intro.mdx
  • site/docs/storybook/Tokens.mdx
  • site/package.json
  • site/pnpm-workspace.yaml
  • site/tsconfig.json
  • src/renderer/src/components/Accordion/Accordion.stories.tsx
  • src/renderer/src/components/AppIcon/AppIcon.stories.tsx
  • src/renderer/src/components/CacheRow/CacheRow.stories.tsx
  • src/renderer/src/components/FrameworkIcon/FrameworkIcon.stories.tsx
  • src/renderer/src/components/Gauge/Gauge.stories.tsx
  • src/renderer/src/components/Glyph/Glyph.stories.tsx
  • src/renderer/src/components/Kbd/Kbd.stories.tsx
  • src/renderer/src/components/LiveDot/LiveDot.stories.tsx
  • src/renderer/src/components/MItem/MItem.stories.tsx
  • src/renderer/src/components/MiniRow/MiniRow.stories.tsx
  • src/renderer/src/components/PackageRow/PackageRow.stories.tsx
  • src/renderer/src/components/PingBadge/PingBadge.stories.tsx
  • src/renderer/src/components/PixelMeter/PixelMeter.stories.tsx
  • src/renderer/src/components/PixelStepper/PixelStepper.stories.tsx
  • src/renderer/src/components/PnpmStoreSettings/PnpmStoreSettings.stories.tsx
  • src/renderer/src/components/ProjectIcon/ProjectIcon.stories.tsx
  • src/renderer/src/components/RescanHint/RescanHint.stories.tsx
  • src/renderer/src/components/ResultView/ResultView.stories.tsx
  • src/renderer/src/components/Row/Row.stories.tsx
  • src/renderer/src/components/ScanLocationsSettings/ScanLocationsSettings.stories.tsx
  • src/renderer/src/components/Segmented/Segmented.stories.tsx
  • src/renderer/src/components/SeverityMeter/SeverityMeter.stories.tsx
  • src/renderer/src/components/SizeViz/SizeViz.stories.tsx
  • src/renderer/src/components/Spinner/Spinner.stories.tsx
  • src/renderer/src/components/TabHeadline/TabHeadline.stories.tsx
  • src/renderer/src/components/Toggle/Toggle.stories.tsx
  • src/renderer/src/components/TypeBadge/TypeBadge.stories.tsx
  • src/renderer/src/components/UIIcon/UIIcon.stories.tsx
  • src/renderer/src/components/UnlockPrompt/UnlockPrompt.stories.tsx
  • src/renderer/src/components/UpdateBanner/UpdateBanner.stories.tsx
  • src/renderer/src/components/UpdateSettings/UpdateSettings.stories.tsx
  • src/renderer/src/components/stories-coverage.test.ts
  • tsconfig.web.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

AhmedFr added a commit that referenced this pull request Aug 3, 2026
…rerun green

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Union resolutions in package.json/.gitignore/CLAUDE.md/STATUS.html;
pnpm-lock regenerated (vitest unified on 3). stories-coverage.test.ts
pinned to the node environment — under the renderer project's jsdom,
import.meta.url is not a file: URL in vitest 3.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@AhmedFr
AhmedFr merged commit 747695f into main Aug 3, 2026
6 checks passed
@AhmedFr
AhmedFr deleted the feat/storybook branch August 3, 2026 12:42

This branch was successfully deployed

1 active deployment
Preview — 8225c7d5 Deployed Aug 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant