Skip to content

fix: give job sources 30 seconds instead of 10 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
berkayturk wants to merge 1 commit into from
Closed

fix: give job sources 30 seconds instead of 10 #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/lib/job-search/http.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,13 @@ describe("requestJson", () => {
await expect(requestJson("JSEARCH", url)).rejects.toMatchObject({ problem: "changed" });
});

it("gives a source 30 seconds, as JSearch can take over 10 on a search it hasn't seen", async () => {
const timeout = vi.spyOn(AbortSignal, "timeout");
stubFetch(() => Response.json({ ok: true }));
await requestJson("JSEARCH", url);
expect(timeout).toHaveBeenCalledWith(30_000);
});

it("says it timed out when the source takes too long", async () => {
vi.spyOn(AbortSignal, "timeout").mockReturnValue(AbortSignal.abort());
stubFetch((_, signal) => Promise.reject(signal?.reason ?? new Error("aborted")));
Expand Down
4 changes: 3 additions & 1 deletion src/lib/job-search/http.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import type { JobSource } from "./search";
// fetching a posting (src/lib/posting-fetch.ts) there's no address to guard;
// requests are still limited in time and size.

export const REQUEST_TIMEOUT_MS = 10_000;
// JSearch can take over 10 seconds on a search it hasn't run before; the
// agent searches once a day, so a timeout there costs the whole run.
export const REQUEST_TIMEOUT_MS = 30_000;
const MAX_BYTES = 5 * 1024 * 1024;

/** GETs JSON from a source, turning every failure into a JobSearchError. */
Expand Down