Repository navigation
Link the resume's contact details - #25
Closed
rahulrathore95 wants to merge 1 commit into
Closed
rahulrathore95 wants to merge 1 commit into
rahulrathore95 wants to merge 1 commit into
Conversation
Email, phone, website and LinkedIn in the resume header were plain
text; they're clickable now (mailto:, tel: and https:), styled the
same muted, underline-free way as a publication's citation link
already was. City/country and age have no link, same as before.
ResumeContent.contacts changed shape (string[] -> {text, href}[]) for
this. contactItems(), used by the cover letter's own sender block
(free text the user can edit), still returns plain strings -
untouched.
Verified: yarn typecheck, yarn lint and yarn test (full suite) all
pass, 1682 tests, 0 failures; resume snapshots regenerated and
reviewed across every theme (only the new <a> wrapping changed,
nothing else moved).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Author
|
Closing this — I'm going to keep this work on my own fork instead of submitting it back upstream. Thanks for the earlier feedback on splitting it up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out of #22 per your request. One change: email, phone, website and LinkedIn in the resume header were plain text; they're clickable now (
mailto:,tel:andhttps:), styled the same muted, underline-free way as a publication's citation link already was. City/country and age have no link, same as before.ResumeContent.contactschanged shape (string[]→{text, href}[]) for this.contactItems(), used by the cover letter's own sender block (free text the user can edit), still returns plain strings — untouched.Test plan
yarn typecheck,yarn lint,yarn test(full suite): 1682 passed, 0 failures.<a>wrapping changed, nothing else moved.resume-content.test.ts.🤖 Generated with Claude Code