Store body_raw as well as a fix for bb report#649
Draft
bitterpanda63 wants to merge 1 commit into
Draft
Conversation
|
|
||
|
|
||
| def test_body_raw_set_when_bytes_json_parsed(): | ||
| # Regression: AIKIDO-FVRDOX5M — json.loads decodes unicode escapes (e.g. # -> #) |
Contributor
There was a problem hiding this comment.
don't need to mention the report id
| if parsed_body: | ||
| # Save the raw decoded string so injection detection still works | ||
| # against code that reads the body as raw bytes/string. json.loads | ||
| # decodes unicode escapes (e.g. # -> #), creating a mismatch |
Contributor
There was a problem hiding this comment.
Suggested change
| # decodes unicode escapes (e.g. # -> #), creating a mismatch | |
| # decodes unicode escapes (e.g. \u0023 -> #), creating a mismatch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.