Skip to content

Add conflict detection for PortRetry plugins and update documentation - #10

Merged
Ajimaru merged 4 commits into
mainfrom
dev
Sep 11, 2026
Merged

Ajimaru merged 4 commits into
mainfrom
dev

Conversation

@Ajimaru

@Ajimaru Ajimaru commented Sep 11, 2026

Copy link
Copy Markdown
Owner

This pull request introduces a robust mechanism to detect and warn users if conflicting automatic reconnect plugins are enabled in OctoPrint, specifically targeting the original PortRetry and PortRetryPlus plugins. The changes ensure that only one reconnect plugin is active at a time to prevent competing reconnection attempts, and provide clear user feedback through the UI. Additional improvements include documentation updates and minor metadata corrections.

Conflict detection and user warning system:

  • Added backend logic in octoprint_autoconnectplus/__init__.py to detect if portretry or portretryplus plugins are enabled, returning this information in the API for the settings dialog and UI use. [1] [2] [3]
  • Implemented frontend logic in octoprint_autoconnectplus/static/js/autoconnectplus.js to display a permanent error toast if a conflict is detected, both on initial load and when the settings dialog is opened. [1] [2]

Documentation and user guidance:

  • Updated README.md and extras/autoconnectplus.md to clearly document that only one reconnect plugin should be active, how conflicts are detected, and the resulting user experience. [1] [2] [3]
  • Improved attribution and clarified project origin and guidelines in README.md and plugin metadata. [1] [2] [3]

Testing and metadata:

  • Enhanced tests in tests/test_plugin.py to verify correct detection and reporting of enabled PortRetry plugins. [1] [2]
  • Finalized package version to 0.1.0 in pyproject.toml.

Dependabot configuration:

  • Updated .github/dependabot.yml to add grouped and scheduled updates for GitHub Actions and pip dependencies, targeting the dev branch and reducing PR noise.

@Ajimaru Ajimaru self-assigned this Sep 11, 2026
@Ajimaru Ajimaru added documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code labels Sep 11, 2026
Signed-off-by: Hi My Name Is <38381946+Ajimaru@users.noreply.github.com>
@Ajimaru
Ajimaru merged commit 13ecb14 into main Sep 11, 2026
13 checks passed
@codacy-production

Copy link
Copy Markdown

Not up to standards ⛔

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 178 complexity · 0 duplication

Metric Results
Complexity 178
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request github_actions Pull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant