Conversation
The check ran at DOM-ready, before OctoPrint's client had its base URL set, so every page load requested /undefined/api/plugin/autoconnectplus (404) and the conflict warning never showed. The API is login-protected anyway, so run the check from the view model's onUserLoggedIn. Also stop ignoring editor/assistant files in .gitignore. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the
octoprint_autoconnectplusplugin to improve when port retry conflict checks are performed and bumps the plugin version. The main change is to trigger the conflict check after user login, ensuring the API is available, instead of immediately at page load.Behavior change:
onUserLoggedIn), rather than immediately after the plugin assets are ready. This avoids issues with undefined API base URLs and missing sessions at DOM-ready time. (octoprint_autoconnectplus/static/js/autoconnectplus.js, [1] [2]Version update:
0.1.0to0.1.1to reflect this behavioral change. (pyproject.toml, pyproject.tomlL7-R7)