Repository navigation
swift-subprocess - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR integrates the official
swift-subprocesspackage intoXSTooling.To maintain flexibility, this dependency is introduced conditionally behind a new feature trait:
--traits EnableSubprocess.Context & Motivation
On Linux environments, the existing implementation suffers from a critical known bug in Swift Corelibs Foundation related to
FileHandle.readabilityHandler. It frequently fails to trigger on EOF or completely hangs during asynchronous process I/O tracking.For reference, see the official tracker issues:
readabilityHandleron pipe that is Process output hangs on Linux.The modern
swift-subprocesslibrary leverages Swift Concurrency natively (async/await) and completely bypasses these legacy low-level Foundation limitations on Linux.Platform-specific Requirements:
EnableSubprocesstrait is mandatory to ensure reliable, non-blocking process execution and streaming.readabilityHandlerworks as expected.