[Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [ML] Fix for memory issue in ML headers by ChSonnabend · Pull Request #17836 · AliceO2Group/O2Physics

ChSonnabend · 2026-09-08T18:24:22Z

This PR fixes the dangling float* pointers and replaces it with a std::vector allocation.

alibuild · 2026-09-21T10:20:22Z

Error while checking build/O2Physics/code-check for b983840 at 2026-09-22 01:21:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/Common/Tools/PID/pidTPCModule.h:612:82: error: 'class std::unique_ptr<float []>' has no member named 'begin'
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-21T10:21:32Z

Error while checking build/O2Physics/staging for b983840 at 2026-09-21 20:19:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:612:82: error: 'class std::unique_ptr<float []>' has no member named 'begin'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:612:82: error: 'class std::unique_ptr<float []>' has no member named 'begin'
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:612:82: error: 'class std::unique_ptr<float []>' has no member named 'begin'
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-21T10:28:38Z

Error while checking build/O2Physics/o2 for b983840 at 2026-09-22 03:46:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/Common/Tools/PID/pidTPCModule.h:612:82: error: 'class std::unique_ptr<float []>' has no member named 'begin'
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-27T19:49:35Z

Error while checking build/O2Physics/staging for 4e7f6ff at 2026-09-27 22:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:572:41: error: 'track_prop_size' was not declared in this scope; did you mean 'trackPropSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:603:9: error: 'trackProperties' was not declared in this scope; did you mean 'track_properties'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:603:25: error: 'counterTrackProps' was not declared in this scope; did you mean 'counter_track_props'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:608:71: error: 'nNclNormalization' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:629:7: error: 'duration_network' was not declared in this scope; did you mean 'output_network'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:630:36: error: 'prediction_size' was not declared in this scope; did you mean 'predictionSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:633:63: error: 'network_prediction' was not declared in this scope; did you mean 'networkPrediction'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:633:90: error: 'prediction_size' was not declared in this scope; did you mean 'predictionSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:635:7: error: 'counterTrackProps' was not declared in this scope; did you mean 'counter_track_props'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:636:9: error: 'loopCounter' was not declared in this scope; did you mean 'loop_counter'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:638:5: error: 'trackProperties' was not declared in this scope; did you mean 'track_properties'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:641:105: error: 'durationNetwork' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-27T19:53:36Z

Error while checking build/O2Physics/code-check for 4e7f6ff at 2026-09-27 22:21:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:572:41: error: 'track_prop_size' was not declared in this scope; did you mean 'trackPropSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:603:9: error: 'trackProperties' was not declared in this scope; did you mean 'track_properties'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:603:25: error: 'counterTrackProps' was not declared in this scope; did you mean 'counter_track_props'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:608:71: error: 'nNclNormalization' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:629:7: error: 'duration_network' was not declared in this scope; did you mean 'output_network'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:630:36: error: 'prediction_size' was not declared in this scope; did you mean 'predictionSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:633:63: error: 'network_prediction' was not declared in this scope; did you mean 'networkPrediction'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:633:90: error: 'prediction_size' was not declared in this scope; did you mean 'predictionSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:635:7: error: 'counterTrackProps' was not declared in this scope; did you mean 'counter_track_props'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:636:9: error: 'loopCounter' was not declared in this scope; did you mean 'loop_counter'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:638:5: error: 'trackProperties' was not declared in this scope; did you mean 'track_properties'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:641:105: error: 'durationNetwork' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-27T19:54:46Z

Error while checking build/O2Physics/o2 for 4e7f6ff at 2026-09-27 22:02:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:572:41: error: 'track_prop_size' was not declared in this scope; did you mean 'trackPropSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:603:9: error: 'trackProperties' was not declared in this scope; did you mean 'track_properties'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:603:25: error: 'counterTrackProps' was not declared in this scope; did you mean 'counter_track_props'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:608:71: error: 'nNclNormalization' was not declared in this scope
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:629:7: error: 'duration_network' was not declared in this scope; did you mean 'output_network'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:630:36: error: 'prediction_size' was not declared in this scope; did you mean 'predictionSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:633:63: error: 'network_prediction' was not declared in this scope; did you mean 'networkPrediction'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:633:90: error: 'prediction_size' was not declared in this scope; did you mean 'predictionSize'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:635:7: error: 'counterTrackProps' was not declared in this scope; did you mean 'counter_track_props'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:636:9: error: 'loopCounter' was not declared in this scope; did you mean 'loop_counter'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:638:5: error: 'trackProperties' was not declared in this scope; did you mean 'track_properties'?
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/Common/Tools/PID/pidTPCModule.h:641:105: error: 'durationNetwork' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

alibuild · 2026-09-27T21:11:48Z

Error while checking build/O2Physics/staging for 9f990a6 at 2026-09-27 23:11:

No log files found

Full log here.

alibuild · 2026-09-27T21:26:41Z

Error while checking build/O2Physics/code-check for 9f990a6 at 2026-09-28 05:35:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 3 errors and 457 warnings.'
Found 3 errors and 457 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/b4a6273b86db6b1c14daf6c4a9d1a35a6db0f0b6/O2Physics-code-check/errors.txt
Common/Tools/PID/pidTPCModule.h:471:20: error: no header providing "std::array" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGHF/TableProducer/candidateSelectorLcPidMl.cxx:154:11: error: 'emplace_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
Tools/ML/model.h:25:1: error: included header onnxruntime_c_api.h is not used directly [misc-include-cleaner,-warnings-as-errors]
++ [[ 457 -gt 0 ]]
++ cat /sw/BUILD/b4a6273b86db6b1c14daf6c4a9d1a35a6db0f0b6/O2Physics-code-check/warnings.txt
Common/Tools/PID/pidTPCModule.h:64:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
Common/Tools/PID/pidTPCModule.h:66:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Common/Tools/PID/pidTPCModule.h:105:82: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:106:76: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:111:94: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:186:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:195:28: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
Common/Tools/PID/pidTPCModule.h:232:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/PID/pidTPCModule.h:278:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:282:17: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:295:15: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:358:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:416:7: warning: do not use 'else' after 'return' [readability-else-after-return]
Common/Tools/PID/pidTPCModule.h:425:191: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:425:241: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:434:15: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:454:19: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:466:35: warning: initializer for member 'versionName' is redundant [readability-redundant-member-init]
Common/Tools/PID/pidTPCModule.h:502:13: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:538:189: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:538:239: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:565:34: warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions]
Common/Tools/PID/pidTPCModule.h:570:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:585:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:591:37: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:658:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:660:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:666:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:668:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:676:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:678:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:710:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:712:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:778:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:803:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:811:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:841:16: warning: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables]
[0 more errors; see full log]

Full log here.

alibuild · 2026-09-28T12:11:20Z

Error while checking build/O2Physics/code-check for 7b8b225 at 2026-09-28 14:11:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 5 errors and 457 warnings.'
Found 5 errors and 457 warnings.
++ [[ 5 -gt 0 ]]
++ cat /sw/BUILD/d2397887e9768d9d729f2b36fbcf8828a43d6d8a/O2Physics-code-check/errors.txt
PWGHF/TableProducer/candidateSelectorLcPidMl.cxx:154:11: error: 'emplace_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
Tools/ML/model.cxx:90:46: error: no header providing "GraphOptimizationLevel" is directly included [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.cxx:93:37: error: no header providing "ORT_LOGGING_LEVEL_WARNING" is directly included [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.cxx:95:41: error: no header providing "OrtAllocatorType" is directly included [misc-include-cleaner,-warnings-as-errors]
Tools/ML/model.cxx:95:78: error: no header providing "OrtMemType" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 457 -gt 0 ]]
++ cat /sw/BUILD/d2397887e9768d9d729f2b36fbcf8828a43d6d8a/O2Physics-code-check/warnings.txt
Common/Tools/PID/pidTPCModule.h:65:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
Common/Tools/PID/pidTPCModule.h:67:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Common/Tools/PID/pidTPCModule.h:106:82: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:107:76: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:112:94: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:187:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:196:28: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
Common/Tools/PID/pidTPCModule.h:233:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/PID/pidTPCModule.h:279:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:283:17: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:296:15: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:359:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:417:7: warning: do not use 'else' after 'return' [readability-else-after-return]
Common/Tools/PID/pidTPCModule.h:426:191: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:426:241: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:435:15: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:455:19: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:467:35: warning: initializer for member 'versionName' is redundant [readability-redundant-member-init]
Common/Tools/PID/pidTPCModule.h:503:13: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:539:189: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:539:239: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:566:34: warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions]
Common/Tools/PID/pidTPCModule.h:571:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:586:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:592:37: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:659:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:661:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:667:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:669:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:677:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:679:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:711:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:713:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:779:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:804:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
[0 more errors; see full log]

Full log here.

alibuild · 2026-09-28T12:12:25Z

Error while checking build/O2Physics/staging for 7b8b225 at 2026-09-28 14:12:

No log files found

Full log here.

vkucera · 2026-09-28T12:40:14Z

Hi @ChSonnabend . The onnxruntime_c_api.h include should stay in both model files. The error comes from changes in other modified files in the PR.

vkucera · 2026-09-28T12:43:42Z

Hi @ChSonnabend . The onnxruntime_c_api.h include should stay in both model files. The error comes from changes in other modified files in the PR.

Sorry, I take it back. It is indeed not needed any more in model.h since you removed the code that was using OrtAllocatorType, OrtMemType provided by the header.

alibuild · 2026-09-28T14:20:16Z

Error while checking build/O2Physics/code-check for 45f58c0 at 2026-09-28 16:20:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 457 warnings.'
Found 1 errors and 457 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/f255ee0f1435642c93322e0bf50c118f6eea5ed3/O2Physics-code-check/errors.txt
PWGHF/TableProducer/candidateSelectorLcPidMl.cxx:154:11: error: 'emplace_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
++ [[ 457 -gt 0 ]]
++ cat /sw/BUILD/f255ee0f1435642c93322e0bf50c118f6eea5ed3/O2Physics-code-check/warnings.txt
Common/Tools/PID/pidTPCModule.h:65:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
Common/Tools/PID/pidTPCModule.h:67:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Common/Tools/PID/pidTPCModule.h:106:82: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:107:76: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:112:94: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:187:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:196:28: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
Common/Tools/PID/pidTPCModule.h:233:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/PID/pidTPCModule.h:279:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:283:17: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:296:15: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:359:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:417:7: warning: do not use 'else' after 'return' [readability-else-after-return]
Common/Tools/PID/pidTPCModule.h:426:191: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:426:241: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:435:15: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:455:19: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:467:35: warning: initializer for member 'versionName' is redundant [readability-redundant-member-init]
Common/Tools/PID/pidTPCModule.h:503:13: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:539:189: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:539:239: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:566:34: warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions]
Common/Tools/PID/pidTPCModule.h:571:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:586:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:592:37: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:659:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:661:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:667:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:669:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:677:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:679:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:711:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:713:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:779:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:804:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:812:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:842:16: warning: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables]
Common/Tools/PID/pidTPCModule.h:843:13: warning: variable 'occupancy' is not initialized [cppcoreguidelines-init-variables]
Common/Tools/PID/pidTPCModule.h:863:39: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Please consider the following formatting changes to AliceO2Group#17836

alibuild · 2026-09-28T20:22:17Z

Error while checking build/O2Physics/staging for 8334da5 at 2026-09-28 22:22:

No log files found

Full log here.

ChSonnabend · 2026-09-28T20:22:37Z

TPC PID task validated on small test-AO2D, ready to merge from my side

alibuild · 2026-09-28T20:50:28Z

Error while checking build/O2Physics/code-check for 8334da5 at 2026-09-28 22:50:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 457 warnings.'
Found 1 errors and 457 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/c3013f8c4beca4c0dafe1e69d19a51fa4e1aa794/O2Physics-code-check/errors.txt
PWGHF/TableProducer/candidateSelectorLcPidMl.cxx:154:11: error: 'emplace_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation,-warnings-as-errors]
++ [[ 457 -gt 0 ]]
++ cat /sw/BUILD/c3013f8c4beca4c0dafe1e69d19a51fa4e1aa794/O2Physics-code-check/warnings.txt
Common/Tools/PID/pidTPCModule.h:65:10: warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath' instead [modernize-deprecated-headers]
Common/Tools/PID/pidTPCModule.h:67:1: warning: nested namespaces can be concatenated [modernize-concat-nested-namespaces]
Common/Tools/PID/pidTPCModule.h:106:82: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:107:76: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:112:94: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
Common/Tools/PID/pidTPCModule.h:187:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:196:28: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
Common/Tools/PID/pidTPCModule.h:233:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/PID/pidTPCModule.h:279:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:283:17: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:296:15: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:359:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:417:7: warning: do not use 'else' after 'return' [readability-else-after-return]
Common/Tools/PID/pidTPCModule.h:426:191: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:426:241: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:435:15: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:455:19: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:467:35: warning: initializer for member 'versionName' is redundant [readability-redundant-member-init]
Common/Tools/PID/pidTPCModule.h:503:13: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
Common/Tools/PID/pidTPCModule.h:539:189: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:539:239: warning: use nullptr [modernize-use-nullptr]
Common/Tools/PID/pidTPCModule.h:566:34: warning: narrowing conversion from 'double' to 'int' [bugprone-narrowing-conversions]
Common/Tools/PID/pidTPCModule.h:571:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:586:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:592:37: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:659:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:661:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:667:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:669:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:677:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:679:20: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:711:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:713:18: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/PID/pidTPCModule.h:779:21: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
Common/Tools/PID/pidTPCModule.h:804:13: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:812:11: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/PID/pidTPCModule.h:842:16: warning: variable 'hadronicRate' is not initialized [cppcoreguidelines-init-variables]
Common/Tools/PID/pidTPCModule.h:843:13: warning: variable 'occupancy' is not initialized [cppcoreguidelines-init-variables]
Common/Tools/PID/pidTPCModule.h:863:39: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

dsekihat · 2026-09-29T10:38:55Z

Dear @ChSonnabend , Thank you for this PR. Just to be clear, can you remove [WIP] from the title?

ChSonnabend added 2 commits September 8, 2026 20:18

Updating ML model class with safe copies, avoiding memory overwrites

8075964

Merge branch 'master' into mlfix

be8a4a7

ChSonnabend added 2 commits September 21, 2026 10:51

Merge branch 'master' into mlfix

8541987

Adjusting for better compute performance

b983840

ChSonnabend added 2 commits September 27, 2026 21:29

Fix for .begin() to .get()

7243322

Merge branch 'master' into mlfix

4e7f6ff

Fixes

9f990a6

Fix CI errors

7b8b225

alibuild mentioned this pull request Sep 28, 2026

Please consider the following formatting changes to #17836 ChSonnabend/O2Physics#18

Merged

ChSonnabend and others added 2 commits September 28, 2026 14:16

Adding back onnxruntime_c_api

45f58c0

Please consider the following formatting changes

064e986

Merge pull request #18 from alibuild/alibot-cleanup-17836

8334da5

Please consider the following formatting changes to AliceO2Group#17836

dsekihat approved these changes Sep 29, 2026

View reviewed changes

ChSonnabend changed the title ~~[Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [WIP] [ML] Fix for memory issue in ML headers~~ [Infrastructure,Tools,Common,Tutorial,PWGDQ,PWGHF,PWGLF] [ML] Fix for memory issue in ML headers Sep 29, 2026

dsekihat merged commit abafa83 into AliceO2Group:master Sep 29, 2026
14 of 16 checks passed

Conversation

ChSonnabend commented Sep 8, 2026

Uh oh!

alibuild commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 27, 2026

Uh oh!

alibuild commented Sep 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alibuild commented Sep 28, 2026

Uh oh!

alibuild commented Sep 28, 2026

Uh oh!

vkucera commented Sep 28, 2026

Uh oh!

vkucera commented Sep 28, 2026

Uh oh!

alibuild commented Sep 28, 2026

Uh oh!

alibuild commented Sep 28, 2026

Uh oh!

ChSonnabend commented Sep 28, 2026

Uh oh!

alibuild commented Sep 28, 2026

Uh oh!

dsekihat commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

5 participants

alibuild commented Sep 21, 2026 •

edited

Loading

alibuild commented Sep 21, 2026 •

edited

Loading

alibuild commented Sep 21, 2026 •

edited

Loading

alibuild commented Sep 27, 2026 •

edited

Loading

alibuild commented Sep 27, 2026 •

edited

Loading

alibuild commented Sep 27, 2026 •

edited

Loading

alibuild commented Sep 27, 2026 •

edited

Loading

dsekihat commented Sep 29, 2026 •

edited

Loading