[PWGDQ] Fixing reserve issue and adding extra cut

[lucamicheletti93]

Fixing reserve issue and adding extra cut

[github-actions]

O2 linter results: ❌ 28 errors, ⚠️ 267 warnings, 🔕 91 disabled

[vkucera]

@lucamicheletti93 Please follow the instructions in https://mattermost.web.cern.ch/alice/pl/99iaahakqprtjyzh53fadb9nzo

[alibuild]

Error while checking build/O2Physics/code-check for f67fb5c at 2026-09-09 16:47:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 11 errors and 35 warnings.'
Found 11 errors and 35 warnings.
++ [[ 11 -gt 0 ]]
++ cat /sw/BUILD/abdf5c7c1e787dea90e6f54f30d94e701e67fe09/O2Physics-code-check/errors.txt
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:69:6: error: variable 'vecBinsPt' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:69:38: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:69:46: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:105:8: error: constructor does not initialize these fields: fEventCut [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:406:32: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:443:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:552:31: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/taskFwdTrackPid.cxx:61:8: error: constructor does not initialize these fields: fHistMan [cppcoreguidelines-pro-type-member-init,-warnings-as-errors]
PWGDQ/Tasks/taskFwdTrackPid.cxx:85:34: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/taskFwdTrackPid.cxx:85:63: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
PWGDQ/Tasks/taskFwdTrackPid.cxx:185:74: error: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay,-warnings-as-errors]
++ [[ 35 -gt 0 ]]
++ cat /sw/BUILD/abdf5c7c1e787dea90e6f54f30d94e701e67fe09/O2Physics-code-check/warnings.txt
PWGDQ/Core/CutsLibrary.cxx:7556:33: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:7586:35: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:7593:35: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:7604:35: warning: use 'contains' to check for membership [readability-container-contains]
PWGDQ/Core/CutsLibrary.cxx:7959:21: warning: redundant string initialization [readability-redundant-string-init]
PWGDQ/Core/CutsLibrary.cxx:8003:7: warning: do not use 'else' after 'return' [readability-else-after-return]
PWGDQ/Core/CutsLibrary.cxx:8034:10: warning: avoid repeating the return type from the declaration; use a braced initializer list instead [modernize-return-braced-init-list]
PWGDQ/Core/CutsLibrary.h:122:23: warning: function 'o2::aod::dqcuts::ParseJSONAnalysisCompositeCut' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/Core/CutsLibrary.h:152:37: warning: function 'o2::aod::dqmlcuts::makeLabeledCutsMl' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:65:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:182:11: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:185:32: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:244:12: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:251:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:280:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:285:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:285:40: warning: implicit conversion 'int' -> 'bool' [readability-implicit-bool-conversion]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:286:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:420:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:452:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:455:34: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:460:29: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:467:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:469:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:471:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:473:26: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:485:36: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:560:22: warning: statement should be inside braces [readability-braces-around-statements]
PWGDQ/TableProducer/tableMakerMuonMchTrkEfficiency.cxx:563:34: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

[vkucera]

No fix done so far.

[dsekihat]

PR should not be marked as draft due to the optional checks.

[vkucera]

PR should not be marked as draft due to the optional checks.

Hi @dsekihat The PR was marked as draft because it was not implementing the fix and therefore not ready for merging.

[dsekihat]

Decision on merging PRs is taken by the code owners.

[vkucera]

Decision on merging PRs is taken by the code owners.

And the code owner asked me to express my opinion on the PR. I am not preventing the merging in any way.

[mguilbau]

@dsekihat I confirmed what @vkucera said.

[dsekihat]

I see. My fault here. My apologizes.

[lucamicheletti93]

Dear all, sorry but last week I was off and I'm slowly recovering messages / mails. I have removed the reserve command that was causing break of the task and as far as I understood it is a possible solution (point 3 of https://mattermost.web.cern.ch/alice/channels/o2-analysis/99iaahakqprtjyzh53fadb9nzo). The PR can be now merged?
Thanks in advance!

[vkucera]

Dear all, sorry but last week I was off and I'm slowly recovering messages / mails. I have removed the reserve command that was causing break of the task and as far as I understood it is a possible solution (point 3 of https://mattermost.web.cern.ch/alice/channels/o2-analysis/99iaahakqprtjyzh53fadb9nzo). The PR can be now merged? Thanks in advance!

Hi @lucamicheletti93 , thanks for the reply. Are you implying that the number of muons per DF is not large enough to make the reserve useful?

[lucamicheletti93]

Hi @vkucera , yes exactly, or in any case more convenient than looping one more time on the collision and track tables to count them and reserve the proper amount of space.

[vkucera]

Hi @vkucera , yes exactly, or in any case more convenient than looping one more time on the collision and track tables to count them and reserve the proper amount of space.

OK, thanks for the clarification.