Skip to content

[PWGLF] Use the real Omega(2012) PDG code in the resonance analysis - #18077

Closed
sawenzel wants to merge 1 commit into
AliceO2Group:masterfrom
sawenzel:fix-omega2012-pdg-placeholder
Closed

[PWGLF] Use the real Omega(2012) PDG code in the resonance analysis#18077
sawenzel wants to merge 1 commit into
AliceO2Group:masterfrom
sawenzel:fix-omega2012-pdg-placeholder

Conversation

@sawenzel

@sawenzel sawenzel commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • omega2012Analysis.cxx used a local kPlaceholderPdgCode = 3335 with a TODO to switch to a real PDG constant once one existed. AliceO2#15820 added o2::constants::physics::Pdg::kOmega2012Minus (123334); this switches the analysis to use it and drops the placeholder.
  • See also AliceO2#15857, which aligns the Geant transport-layer PDG code/mass for Omega(2012) to the same value for full consistency.

@sawenzel
Use the real Omega(2012) PDG code in the resonance analysis
fcf08b0 
This replaces the placeholder PDG code in omega2012Analysis.cxx with
o2::constants::physics::Pdg::kOmega2012Minus, now that AliceO2 carries
that constant.

- Removes kPlaceholderPdgCode (3335) and its TODO.
@github-actions github-actions Bot added the pwglf label Sep 28, 2026
@github-actions

github-actions Bot commented Sep 28, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 3 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Use the real Omega(2012) PDG code in the resonance analysis [PWGLF] Use the real Omega(2012) PDG code in the resonance analysis Sep 28, 2026
@alibuild

alibuild commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for fcf08b0 at 2026-09-28 18:29:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/omega2012Analysis.cxx:973:57: error: 'kOmega2012Minus' is not a member of 'o2::constants::physics::Pdg'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 28, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for fcf08b0 at 2026-09-28 19:00:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGLF/Tasks/Resonances/omega2012Analysis.cxx:973:57: error: 'kOmega2012Minus' is not a member of 'o2::constants::physics::Pdg'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for fcf08b0 at 2026-09-29 06:16:

No log files found

Full log here.

@vkucera

vkucera commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

This seems already done in #17978

@sawenzel

sawenzel commented Sep 29, 2026

Copy link
Copy Markdown
Contributor Author

Indeed.

@sawenzel sawenzel closed this Sep 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner

Assignees

No one assigned

Labels

pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sawenzel @alibuild @vkucera