Skip to content

[PWGJE] Add hasColl and collision-environment QA to jet cross-section efficiency - #18083

Merged
nzardosh merged 2 commits into
AliceO2Group:masterfrom
Hamwooseok:hascoll-environment-qa
Sep 29, 2026
Merged

nzardosh merged 2 commits into
AliceO2Group:masterfrom
Hamwooseok:hascoll-environment-qa

Conversation

@Hamwooseok

Copy link
Copy Markdown
Contributor

This PR adds optional QA processes to "jetCrossSectionEfficiency" to study the reconstructed-collision ("hasColl") inefficiency and its dependence on the collision environment.

  1. processDataTVXBCEnvironmentQA
  • Measures the data-visible TVX-BC environment using the number of other TVX BCs in the same ITS ROF, the nearest TVX BC distance, and FT0C activity.
  • Provides a reconstructed-collision proxy for direct Data/MC comparison.
  1. processMCEnvironmentQA
  • Performs the corresponding visible TVX-BC QA in MC.
  • Studies the dependence of "hasColl" on the truth collision environment.
  • Compares the truth and TVX-visible environment and validates the reconstructed-collision proxy against the JetDerived "hasColl" definition.
  1. processMCHasCollTrackFateQA
  • Checks whether tracks originating from MC collisions that fail "hasColl" are still reconstructed, unassigned, or associated with other reconstructed collisions.
  1. processMCHasCollJetSurvivalQA
  • Studies whether MCP jets from "hasColl" and "noColl" collisions survive at detector level and how much of the reconstructed constituent momentum is captured by detector-level jets.
  1. processMCHasCollJetEnvironmentQA
  • Stores selected MCP jets as a function of the visible TVX-BC environment and "hasColl", allowing the jet-level "hasColl" efficiency to be reweighted to the Data collision environment.

All newly added QA processes are disabled by default. Data- and MC-only processes are explicitly separated, and the existing cross-section-efficiency selection logic is unchanged.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 4 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title PWGJE: Add hasColl and collision-environment QA to jet cross-section efficiency [PWGJE] Add hasColl and collision-environment QA to jet cross-section efficiency Sep 29, 2026
nzardosh
nzardosh previously approved these changes Sep 29, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 0c135b4 at 2026-09-29 10:47:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 1 warnings.'
Found 1 errors and 1 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/206120736fcaea1e1e7567854eb884e383e113ee/O2Physics-code-check/errors.txt
PWGJE/Tasks/jetCrossSectionEfficiency.cxx:198:98: error: no header providing "o2::aod::track::PVContributor" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/206120736fcaea1e1e7567854eb884e383e113ee/O2Physics-code-check/warnings.txt
PWGJE/Tasks/jetCrossSectionEfficiency.cxx:1003:55: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for ec27efe at 2026-09-29 12:06:

No log files found

Full log here.

@Hamwooseok

Copy link
Copy Markdown
Contributor Author

Hello @nzardosh. The build/O2Physics/staging check failed with No logs found, while the O2Physics build and other required checks passed. Could this be a CI issue, and should it be retriggered?

@nzardosh
nzardosh enabled auto-merge (squash) September 29, 2026 11:52
@nzardosh
nzardosh self-requested a review September 29, 2026 11:53
@nzardosh
nzardosh merged commit 1d577c5 into AliceO2Group:master Sep 29, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants