Skip to content

[DPG] Fix cpplint errors #18096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vkucera merged 1 commit into from
Sep 30, 2026
Merged

[DPG] Fix cpplint errors #18096

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions DPG/Tasks/AOTEvent/detectorOccupancyQa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1087,7 +1087,6 @@ struct DetectorOccupancyQaTask {
// July 2025: more for data vs MC:
if (track.hasTPC() && occupancy >= 0 && confAddBasicQAhistos) {
float pt = track.pt();
// pt 0.2-0.5
if (pt > 0.2 && pt < 0.5) {
if (nPV >= 10 && nPV < 400) {
histos.fill(HIST("QA_noTPCcuts/nPV_10_200/tpcNClsFindable_vs_occup_pt_02_05"), track.tpcNClsFindable(), occupancy);
Expand All @@ -1098,9 +1097,7 @@ struct DetectorOccupancyQaTask {
histos.fill(HIST("QA_noTPCcuts/nPV_above2000/tpcNClsFound_vs_occup_pt_02_05"), track.tpcNClsFound(), occupancy);
histos.fill(HIST("QA_noTPCcuts/nPV_above2000/tpcChi2NCl_vs_occup_pt_02_05"), track.tpcChi2NCl(), occupancy);
}
}
// pt 0.5-1.0
else if (pt > 0.5 && pt < 1.0) {
} else if (pt > 0.5 && pt < 1.0) {
if (nPV >= 10 && nPV < 400) {
histos.fill(HIST("QA_noTPCcuts/nPV_10_200/tpcNClsFindable_vs_occup_pt_05_10"), track.tpcNClsFindable(), occupancy);
histos.fill(HIST("QA_noTPCcuts/nPV_10_200/tpcNClsFound_vs_occup_pt_05_10"), track.tpcNClsFound(), occupancy);
Expand All @@ -1110,9 +1107,7 @@ struct DetectorOccupancyQaTask {
histos.fill(HIST("QA_noTPCcuts/nPV_above2000/tpcNClsFound_vs_occup_pt_05_10"), track.tpcNClsFound(), occupancy);
histos.fill(HIST("QA_noTPCcuts/nPV_above2000/tpcChi2NCl_vs_occup_pt_05_10"), track.tpcChi2NCl(), occupancy);
}
}
// pt > 1.0
else if (pt > 1.0) {
} else if (pt > 1.0) {
if (nPV >= 10 && nPV < 400) {
histos.fill(HIST("QA_noTPCcuts/nPV_10_200/tpcNClsFindable_vs_occup_pt_above1_0"), track.tpcNClsFindable(), occupancy);
histos.fill(HIST("QA_noTPCcuts/nPV_10_200/tpcNClsFound_vs_occup_pt_above1_0"), track.tpcNClsFound(), occupancy);
Expand Down Expand Up @@ -1383,8 +1378,8 @@ struct DetectorOccupancyQaTask {
int tpcNClsFound = track.tpcNClsFound();
int tpcNClsCrossedRows = track.tpcNClsCrossedRows();

if (sign > 0) // positive tracks
{
if (sign > 0) {
// positive tracks
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/PV_hPt_pos"), pt, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/PV_hEta_pos"), eta, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/PV_hPhi_pos"), phi, occupancy, pt);
Expand All @@ -1401,8 +1396,8 @@ struct DetectorOccupancyQaTask {
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/QA_tpcNClsFound_pos"), tpcNClsFound);
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/QA_tpcNClsCrossedRows_pos"), tpcNClsCrossedRows);
}
} else // negative tracks
{
} else {
// negative tracks
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/PV_hPt_neg"), pt, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/PV_hEta_neg"), eta, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_10_200/kine_vs_weighted_occup/PV_hPhi_neg"), phi, occupancy, pt);
Expand Down Expand Up @@ -1449,8 +1444,8 @@ struct DetectorOccupancyQaTask {
} // end of TPC good global

// July 2025: for data vs MC kine distr comparison
if (sign > 0) // positive tracks
{
if (sign > 0) {
// positive tracks
histos.fill(HIST("track_distr_nITStrThisEv_above_2000/kine_vs_weighted_occup/PV_hPt_pos"), pt, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_above_2000/kine_vs_weighted_occup/PV_hEta_pos"), eta, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_above_2000/kine_vs_weighted_occup/PV_hPhi_pos"), phi, occupancy, pt);
Expand All @@ -1463,8 +1458,8 @@ struct DetectorOccupancyQaTask {
histos.fill(HIST("track_distr_nITStrThisEv_above_2000/kine_vs_weighted_occup/hPhi_posModifiedQA"), phi);
}
}
} else // negative tracks
{
} else {
// negative tracks
histos.fill(HIST("track_distr_nITStrThisEv_above_2000/kine_vs_weighted_occup/PV_hPt_neg"), pt, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_above_2000/kine_vs_weighted_occup/PV_hEta_neg"), eta, occupancy);
histos.fill(HIST("track_distr_nITStrThisEv_above_2000/kine_vs_weighted_occup/PV_hPhi_neg"), phi, occupancy, pt);
Expand Down
4 changes: 2 additions & 2 deletions DPG/Tasks/AOTEvent/lightIonsEvSelQa.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,9 +991,9 @@ struct LightIonsEvSelQa {

// vZ diff (FT0 vs by tracks)
bool badVzDiff = 0;
if (confUseDiffVzCutFromEvSel)
if (confUseDiffVzCutFromEvSel) {
badVzDiff = !col.selection_bit(kIsGoodZvtxFT0vsPV);
else { // tune by hand
} else { // tune by hand
float meanDiff = 0.0; // cm
// O-O
if (lastRunNumber == 564356)
Expand Down
Loading